fix(seo): resolve crawlable links and aria-labels#933
fix(seo): resolve crawlable links and aria-labels#933Daniel-1600 wants to merge 1 commit intolayer5io:masterfrom
Conversation
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Daniel-1600
force-pushed
the
fix-seo-issues
branch
from
9bf8dae to
5ea4d48
Compare
|
@Daniel-1600 I'm still not seeing any improvement |
Daniel-1600
force-pushed
the
fix-seo-issues
branch
from
2466e43 to
8aa8ac9
Compare
|
hey @saurabhraghuvanshii after testing from the cli , im seeing no visible errors |
|
@Daniel-1600 but we need seo score. |
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
Thanks for working on this, @Daniel-1600 👍
| icon = "icons/twitter.svg" | ||
| desc = "Follow us on Twitter to get the latest news!" | ||
| class= "social-icon" | ||
| alt = "Twitter Icon" |
There was a problem hiding this comment.
Uh-oh... are we still saying "Twitter", not "X"? Hopefully, we are using the X logo, not the Twitter logo.
Please verify/change, @Daniel-1600. 👍
|
@Daniel-1600 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
@Daniel-1600 are you still chewing on this one? |
|
Merge conflicts, @Daniel-1600 |
|
@Daniel-1600 checking in again... |
|
hey @hamza-mohd yes im working on the issue , i will raise a pr soon |
|
🥂 |
Daniel-1600
force-pushed
the
fix-seo-issues
branch
from
5f3b6a2 to
a7d5822
Compare
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-933/
|
Daniel-1600
force-pushed
the
fix-seo-issues
branch
3 times, most recently
from
064fad2 to
f85fc03
Compare
|
I squashed all my commits to a single commit |
| [[params.links.footer.icons]] | ||
| name = "Twitter" | ||
| name = "X" | ||
| url = "https://twitter.com/layer5" |
There was a problem hiding this comment.
@Daniel-1600 don't you think we should update this link!
There was a problem hiding this comment.
sure lemme make the changes
| name = "Twitter" | ||
| name = "X" | ||
| url = "https://twitter.com/layer5" | ||
| icon = "icons/twitter.svg" |
|
@Daniel-1600 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Daniel-1600
force-pushed
the
fix-seo-issues
branch
2 times, most recently
from
bcc9722 to
c0422fd
Compare
|
@Bhumikagarggg I will add it on the minutes |
|
@saurabhraghuvanshii are the changes okay rn |
|
@Daniel-1600 Please update twitter icon to x icon and all reference. I'm still not seeing any changes |
- Resolve crawlable links in templates - Add aria-labels to navbar icons and dropdowns - Update Twitter branding to X in footer - Fix Lighthouse SEO audit issues Signed-off-by: Daniel Mungai <chegedan699@gmail.com>
Daniel-1600
force-pushed
the
fix-seo-issues
branch
from
c0422fd to
d95d23c
Compare
|
@saurabhraghuvanshii Done. Updated the Twitter icon to X and fixed all related references. Please check now. |
5 participants
Notes for Reviewers
This PR fixes #918
Signed commits