refactor(grammar): modernize string formatting with f-strings and improve type hinting - #1635
Open
ardozcnn wants to merge 2 commits into
Open
refactor(grammar): modernize string formatting with f-strings and improve type hinting#1635ardozcnn wants to merge 2 commits into
ardozcnn wants to merge 2 commits into
Conversation
Member
|
Overall looks okay. You can use tox to run the type checker with the official configuration. |
Author
|
I ran the code can you check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced legacy % string formatting across Symbol, Terminal, RuleOptions, and Rule classes with modern Python f-strings.
Added missing type hints for method parameters (other: Any, memo: Optional[Dict], f: Callable) and return types (-> None, -> str, -> int).
Included empty_indices in RuleOptions.repr to accurately reflect all initialization parameters.
Formatted tuple entries in serialize_fields consistently.