Bugfix: maybe_placeholders pads shorter alternatives of an optional (#1078) - #1629
Open
gaoflow wants to merge 1 commit into
Open
Bugfix: maybe_placeholders pads shorter alternatives of an optional (#1078)#1629gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
…al (Issue lark-parser#1078) An optional group [...] must yield a fixed number of children so consumers can index positionally. When its alternatives differed in width (e.g. ["b" | "c" "d"]), a matched narrower branch was left unpadded while the absent case padded to the widest branch, so arity varied per input. Pad each shorter alternative with trailing placeholders during EBNF expansion, covering nested and non-leading alternations too. Same result on earley and lalr.
gaoflow
force-pushed
the
fix-maybe-placeholders-alternation-arity
branch
from
July 29, 2026 02:55
eebf816 to
2a6381b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe_placeholderspromises an optional[...]group a fixed number of children so consumers can index positionally. When the group's alternatives differ in width, the arity varied per input:maybe()padded only the absent case up to the widest branch; a matched narrower branch was left short. This is the case flagged# Not implemented; current behavior is incorrectintest_maybe_placeholders, and issue #1078 ("the argument count must remain the same whether or not there is a match").The fix pads each shorter alternative with trailing placeholders during EBNF expansion, so every derivation of the optional has the same arity —
"ab"now yields['a', 'b', None]. It also handles nested and non-leading alternations ([("a" | "b" "c") "d"],["a" | "b" "c"] "z"), and leavesmaybe_placeholders=Falseuntouched. Same result on earley and lalr.Re-enables the maintainer's own commented expectation and adds the sibling cases as regression tests.