Skip to content

feat(ci): add RunnerContext and RegressionError for experiment GH action #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wochinge wants to merge 4 commits into
base: main
Choose a base branch
from
+407 −1

feat(experiment): tighten RunnerContext + RegressionError public surface

76c5852
Select commit
Loading
Failed to load commit list.
Open

feat(ci): add RunnerContext and RegressionError for experiment GH action #1635

feat(experiment): tighten RunnerContext + RegressionError public surface
76c5852
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 22, 2026 in 15m 58s

Code review found 1 important issue

Found 5 candidates, confirmed 4. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important langfuse/experiment.py:1072-1093 RunnerContext.init missing run_name — action cannot inject CI run name

Annotations

Check failure on line 1093 in langfuse/experiment.py

See this annotation in the file changed.

@claude claude / Claude Code Review

RunnerContext.__init__ missing run_name — action cannot inject CI run name 

RunnerContext.__init__ does not accept a run_name parameter and stores no self.run_name attribute, so the GitHub Action has no mechanism to inject a CI-meaningful run name (e.g. 'pr-42-sha-abc') as a context-level default. Fix by adding run_name: Optional[str] = None to __init__, storing self.run_name, and resolving it in run_experiment as: resolved_run_name = run_name if run_name is not None else self.run_name.
View more details on Claude