Skip to content

fix(langchain): preserve LangGraph control flow traces #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 7 commits into from
Apr 21, 2026
+983 −58

test(langchain): isolate resume trace assertions

19a231e
Select commit
Loading
Failed to load commit list.
Merged

fix(langchain): preserve LangGraph control flow traces #1632

test(langchain): isolate resume trace assertions
19a231e
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 20, 2026 in 11m 31s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit langfuse/langchain/CallbackHandler.py:949-955 Missing _reset() in root-level control-flow error paths for tool/retriever/LLM handlers

Annotations

Check warning on line 955 in langfuse/langchain/CallbackHandler.py

See this annotation in the file changed.

@claude claude / Claude Code Review

Missing _reset() in root-level control-flow error paths for tool/retriever/LLM handlers 

The three newly-modified error handlers — `on_tool_error` (line 949), `on_retriever_error` (line 309), and `on_llm_error` (line 1161) — call `_persist_resume_trace_context` for root-level control-flow exceptions but never call `_reset()` afterward, unlike `on_chain_error` which correctly includes `_reset()` in its `finally` block. This is a pre-existing gap that the PR makes slightly worse by adding a new side effect (`_persist_resume_trace_context`) without matching cleanup, meaning stale `_chi
View more details on Claude