Skip to content

fix(openai): preserve native v1 stream contract #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hassiebp wants to merge 6 commits into
base: main
Choose a base branch
from
+674 −46

fix(openai): satisfy mypy for stream hooks

95c933d
Select commit
Loading
Failed to load commit list.
Open

fix(openai): preserve native v1 stream contract #1627

fix(openai): satisfy mypy for stream hooks
95c933d
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 16, 2026 in 21m 21s

Code review found 3 potential issues

Found 5 candidates, confirmed 3. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 1
Severity File:Line Issue
🟣 Pre-existing langfuse/openai.py:1293-1308 Fallback async wrapper close/exit paths skip _finalize

Annotations

Check notice on line 1308 in langfuse/openai.py

See this annotation in the file changed.

@claude claude / Claude Code Review

Fallback async wrapper close/exit paths skip _finalize 

The fallback async wrapper's `close()`, `aclose()`, and `__aexit__` methods never call `self._finalize()`, so if a user receives a `LangfuseResponseGeneratorAsync` wrapper (for non-OpenAI generator-style async streams) and closes or context-manages it without iterating, `generation.end()` is never called and the Langfuse span leaks. The same issue exists for `LangfuseResponseGeneratorSync.__exit__`. This is a pre-existing issue that predates this PR; the PR's `_is_finalized` guard improvements t
View more details on Claude