feat(client): allow setting separate tracerprovider#1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Experimental PR review
Greptile Summary
This PR introduces a new feature that allows users to specify a custom OpenTelemetry TracerProvider in the Langfuse Python SDK. The change affects two main files:
resource_manager.pyandclient.py. The key addition is a new optional parametertracer_providerthat gives users more control over their tracing configuration.The changes allow organizations to:
The implementation maintains backward compatibility by making the parameter optional while providing advanced users with full control over their tracing setup.
Confidence score: 5/5
langfuse/_client/client.py: Review the documentation comments for accuracylangfuse/_client/resource_manager.py: Verify the tracer initialization logic2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Important
Add support for custom OpenTelemetry
TracerProviderin Langfuse client and resource manager.tracer_providerparameter toLangfuseclass inclient.pyto allow setting a custom OpenTelemetryTracerProvider.tracer_providerparameter toLangfuseResourceManagerclass inresource_manager.pyfor custom tracing management.tracer_provideris not provided._initialize_instance()inresource_manager.pyto use providedtracer_provideror initialize a new one.__new__()inresource_manager.pyto passtracer_providerto_initialize_instance().client.pyto document the newtracer_providerparameter.This description was created by
for 184c877. You can customize this summary. It will automatically update as commits are pushed.