Skip to content

fix(langchain): deployment version in model name #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 4 commits into from
Jun 4, 2025
Merged

fix(langchain): deployment version in model name #1204

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be6e074
fix(langchain): deployment version in model name
hassiebp Jun 3, 2025
6c1e9f5
push
hassiebp Jun 3, 2025
15e510e
push
hassiebp Jun 3, 2025
325c03f
Merge branch 'main' into fix-langchain-azure-modelname-main
hassiebp Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion langfuse/langchain/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ def _extract_model_name(
deployment_version = None
Comment thread
hassiebp marked this conversation as resolved.
if serialized.get("kwargs").get("deployment_name"):
deployment_name = serialized.get("kwargs").get("deployment_name")
return deployment_name + "-" + deployment_version
return (
deployment_name + "-" + deployment_version
Comment thread
hassiebp marked this conversation as resolved.
if deployment_version not in deployment_name
else deployment_name
)

# Third, for some models, we are unable to extract the model by a path in an object. Langfuse provides us with a string representation of the model pbjects
# We use regex to extract the model from the repr string
Expand Down