Skip to content

Initiation#281

Open
Junhui Cheng (magic-ZSS) wants to merge 5 commits into
langchain-ai:mainfrom
magic-ZSS:initiation
Open

Initiation#281
Junhui Cheng (magic-ZSS) wants to merge 5 commits into
langchain-ai:mainfrom
magic-ZSS:initiation

Conversation

@magic-ZSS

Copy link
Copy Markdown

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c5f365b9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread init.sh
@@ -0,0 +1,19 @@
#!/bin/bash

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore executable bit for init.sh

This script is committed as mode 100644, but the new workflow instructions require running it as ./init.sh; on a fresh checkout that fails with permission denied before any verification can run. Either commit the file with executable mode or change the documented command to bash init.sh.

Useful? React with 👍 / 👎.

Comment thread .env.example
@@ -1,13 +0,0 @@
OPENAI_API_KEY=

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the env template required by quickstart

Deleting this tracked template leaves the README quickstart's cp .env.example .env step without a source file, so clean-clone setup now fails before users can configure model/search keys. Restore the template or update the setup flow to create .env another way.

Useful? React with 👍 / 👎.

@@ -0,0 +1 @@
Subproject commit b58bf73e66868b10faee1ea92acd00f2af42d75b

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add submodule metadata for the tutorial checkout

This adds deep_research_from_scratch as a gitlink, but the commit does not add a matching .gitmodules entry; checking git submodule init reports No url found for submodule path 'deep_research_from_scratch' in .gitmodules. Fresh clones therefore cannot fetch the tutorial contents that the docs now describe, so add the submodule mapping or keep the directory as regular tracked files.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants