fix(legacy): replace bare except with except Exception in utils#246
Open
Luka Aladashvili (llukito) wants to merge 1 commit into
Open
fix(legacy): replace bare except with except Exception in utils#246Luka Aladashvili (llukito) wants to merge 1 commit into
Luka Aladashvili (llukito) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced a bare
except:clause withexcept Exception as e:insrc/legacy/utils.py.Why this matters:
Even in legacy code, bare excepts are problematic as they catch
BaseExceptiontypes likeKeyboardInterruptandSystemExit. This change ensures that users can still terminate long-running processes (like Deep Research agents) via standard signals likeCtrl+C, while maintaining the existing fallback logic for standard errors.