Limit incoming fleet details by espionage technology (#668)#1510
Open
tiweb442 wants to merge 1 commit into
Open
Limit incoming fleet details by espionage technology (#668)#1510tiweb442 wants to merge 1 commit into
tiweb442 wants to merge 1 commit into
Conversation
Redact foreign fleet composition in the event list and fleet movement UI based on the viewer's Espionage Technology level, matching classic OGame rules so low spy tech no longer leaks full ship counts. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Please read CONTRIBUTING.md again. You have multiple pull requests that are open and still under review. I would kindly ask you to stop submitting pull requests so that we have a chance to even review what you are submitting. |
Contributor
Author
sorry i speak french i had to translate to finaly understand i can only work on 1 pr at a time my bad if you see other thing i am doing wrong let me know i also see i am not using the pr template wich i fixed also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?, 8+ full counts; own fleets stay fully visible; foreign fleets never show cargo.Test plan
?amountsphp artisan test --filter='IncomingFleetIntelServiceTest|IncomingFleetEspionageIntelTest'Made with Cursor