feat(152): implement Technology tab in "?" info popup - #1502
Open
tiweb442 wants to merge 3 commits into
Open
Conversation
Show the global technology list with category accordions and prerequisite status to match official OGame. Co-authored-by: Cursor <cursoragent@cursor.com>
Match official OGame CSS (display:none) instead of forcing all category lists open when the tab loads. Co-authored-by: Cursor <cursoragent@cursor.com>
Geda173
approved these changes
Jul 24, 2026
Geda173
left a comment
Collaborator
There was a problem hiding this comment.
Tested it locally and verified both the feature behavior and the test's rigor.
One optional nit for a follow-up (non-blocking): the <a class="prerequisites"> wraps a <ul>, which is invalid HTML nesting. Browsers tolerate it, but worth tidying if it diverges from the surrounding markup conventions.
Replace the ul/li inside a.prerequisites with divs so the markup stays valid while preserving the official OGame CSS selectors. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
Preview deploymentPreview environment for this PR is ready for functional testing. Use one of the test accounts below to log in.
Test accounts (click to expand)
This preview will be automatically destroyed when the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
php artisan test --filter=TechtreeTest