Fix sidebar wreck field icon using wrong planet Space Dock level

[tiweb442]

Summary

In the sidebar planet list, the wreck field icon used the currently selected planet's Space Dock level instead of the iterated planet's.

Fixes #1397

Test plan

• Two planets: wreck on A with Space Dock → icon on A when B is selected
• Wreck on A without Space Dock → no icon on A even if B has Space Dock

Related: tiweb442 #1491, #1492, #1494

Made with Cursor

[Geda173]

Fix looks right. $planet is the @foreach variable from line 1730, and the two lines either side of this one (getPlanetCoordinates() on 1828, isMoon() on 1839) already use it, so this was the odd one out.

Could we get a feature test with it though? This bug is invisible to any single-planet test, because with one planet $planet and planets->current() are the same object. That's why the existing wreck field coverage didn't catch it: 32 tests across FacilitiesWreckFieldTest and WreckFieldTest all pass both with and without this fix. Nothing currently asserts on the sidebar either.

[tiweb442]

@Geda173 Good call — added SidebarWreckFieldIconTest with two multi-planet cases:

1. Wreck + Space Dock on A, B selected without dock → icon on A
2. Wreck on A without dock, B selected with dock → no icon on A

Confirmed both fail against the old planets->current() check and pass with this fix.

[github-actions]

Preview deployment

Status	URL	Commit
❌ Destroyed	pr-1495.preview.ogamex.dev	-

---

Preview environment has been cleaned up.

[Geda173]

Thank you, merging.