Merge main into codeful private preview

.github/workflows/pr-coverage.yml

@@ -92,6 +92,8 @@ jobs:
             **/styles.tsx
             **/*.styles.ts
             **/*.styles.tsx
+            **/*Styles.ts
+            **/*Styles.tsx
             **/constants.ts
             **/constants/**
             # Config files
@@ -135,6 +137,9 @@ jobs:
             **/webviewCommunication.tsx
             # VS Code React intl files (localization catalog, not unit-test target)
             apps/vs-code-react/src/intl/**
+            # Store assembly and webview app composition are covered by lower-level unit tests and E2E
+            apps/vs-code-react/src/state/store.ts
+            apps/vs-code-react/src/app/designer/appV2.tsx
             # VS Code overview React shell (orchestration glue; meaningful logic
             # lives in overview/runtime.ts, services/workflowService.ts, and
             # shared helpers, all of which are unit-tested).
@@ -145,6 +150,10 @@ jobs:
             # Environment-specific utility excluded from coverage policy
             apps/vs-code-designer/src/app/utils/codeless/getAuthorizationToken.ts
             apps/vs-code-designer/src/app/commands/logstream/startStreamingLogs.ts
+            apps/vs-code-designer/src/app/languageServer/languageServer.ts
+            apps/vs-code-designer/src/app/commands/deploy/deploy.ts
+            apps/vs-code-designer/src/app/commands/workflows/exportLogicApp.ts
+            apps/vs-code-designer/src/app/utils/startRuntimeApi.ts
             apps/vs-code-designer/src/extensionVariables.ts
             apps/vs-code-designer/src/main.ts
 

.gitignore

@@ -41,6 +41,8 @@ testem.log
 debug.log
 
 # vscode e2e exTester artifacts
+/.tmp-e2e/
+/.tmp-vitest/
 /apps/vs-code-designer/test-resources
 test-resources
 test-extensions

.vscode/launch.json

@@ -12,7 +12,8 @@
       "outFiles": ["${workspaceFolder}/apps/vs-code-designer/dist/*.js"],
       "preLaunchTask": "npm: build:extension",
       "env": {
-        "DEBUGTELEMETRY": "v"
+        "DEBUGTELEMETRY": "v",
+        "LSP_SERVER_DEV_PATH": "/Users/carloscastro/Documents/Dev/Agent_C_Sharp_Server/Server/bin/Debug/net8.0/SdkLspServer.dll"
       }
     }
   ]

LESS_FILES_MIGRATION_ANALYSIS.md

@@ -15,7 +15,7 @@ This document provides a detailed analysis of all 124 LESS files in the LogicApp
 - ✅ **reviewList styles.less (32 lines) - REMOVED ENTIRELY** - apps/vs-code-react → reviewListStyles.ts (PR #7907)
 - ✅ **VS Code styles.less (5 lines) - REMOVED ENTIRELY** - apps/vs-code-react → inline HTML styles
 - ✅ SVG icon migration (3 files removed) - apps/vs-code-react
-- ✅ **nodeSearchPanel** - NEW makeStyles implementation with Tabster focus management (branch: ccastrotrejo/panelSearchMigration)
+- ✅ **nodeSearchPanel** - NEW makeStyles implementation with Tabster focus management
 - ✅ **Fluent UI v8 to v9 Component Migrations**:
   - SearchableDropdown: Complete migration with proper key handling and Fluent UI v9 patterns
   - ShimmeredDetailsList → Table: Native Fluent UI v9 table with column resizing

LESS_TO_MAKESTYLES_DETAILED_MIGRATION_PLAN.md

@@ -426,7 +426,7 @@ This document provides a detailed, granular breakdown of the LESS to makeStyles
 - In Progress: 5
 - Blocked: 0
 
-### Recently Completed (PRs #7588, #7797, #7820, #7907, Branch: ccastrotrejo/panelSearchMigration)
+### Recently Completed (PRs #7588, #7797, #7820, #7907
 - ✅ VS Code React export.less → exportStyles.ts (PR #7588, #7797)
 - ✅ VS Code React overview.less → overviewStyles.ts (PR #7588)
 - ✅ VS Code React reviewList component styles → reviewListStyles.ts (PR #7907) - **COMPLEX MIGRATION**
@@ -437,7 +437,7 @@ This document provides a detailed, granular breakdown of the LESS to makeStyles
   - Updated all consuming components (validation.tsx, review/index.tsx)
   - Enhanced accessibility with proper ARIA labels and tree navigation
 - ✅ SVG icon migration to Fluent UI icons (PR #7820)
-- ✅ **nodeSearchPanel component**: New makeStyles implementation with Tabster focus management (Branch: ccastrotrejo/panelSearchMigration)
+- ✅ **nodeSearchPanel component**: New makeStyles implementation with Tabster focus management
   - Migrated from Fluent UI v8 `FocusTrapZone` to Tabster for better accessibility
   - Added new dependency: `tabster: 8.5.6`
   - Created `nodeSearchPanelStyles.ts` with makeStyles for SearchBox styling

LESS_TO_MAKESTYLES_MIGRATION_PLAN.md

@@ -33,11 +33,11 @@ This document outlines a comprehensive plan to migrate 124 .less files in the Lo
 - ✅ flyout component (flyout.less - 50 lines) - already had makeStyles, verified
 - ✅ pager component (pager.less - 84 lines)
 - ✅ staticResult component (staticResult.less - 146 lines) - styles created
-- ✅ **nodeSearchPanel** - NEW makeStyles implementation with Tabster focus management (branch: ccastrotrejo/panelSearchMigration)
+- ✅ **nodeSearchPanel** - NEW makeStyles implementation with Tabster focus management
 - ✅ **VS CODE**: export component (export.less - 120 lines) → exportStyles.ts (PR #7588/#7797)
 - ✅ **VS CODE**: overview app (overview.less - 4 lines) → overviewStyles.ts (PR #7588)
 - ✅ **VS CODE**: reviewList component (styles.less - 32 lines) → reviewListStyles.ts (PR #7907) - **COMPLEX MIGRATION**
-- ✅ **VS CODE**: root styles.less (5 lines) → **REMOVED ENTIRELY** - inline HTML styles (ccastrotrejo/FinalMigration)
+- ✅ **VS CODE**: root styles.less (5 lines) → **REMOVED ENTIRELY** - inline HTML styles
 - ✅ **SVG MIGRATION**: 3 SVG files removed, replaced with Fluent UI icons (PR #7820)
 - ✅ **FLUENT UI v8 TO v9 MIGRATIONS** :
   - ✅ SearchableDropdown: Complete v8→v9 migration with enhanced key handling and Fluent UI v9 patterns
@@ -638,7 +638,7 @@ Alongside the LESS to makeStyles migration, we're also migrating from Fluent UI
    - Removed validationItems parameter, simplified component API
    - Complete removal of styles.less file (not just migration)
 
-7. **NodeSearchPanel Component** (✅ COMPLETED - Branch: ccastrotrejo/panelSearchMigration)
+7. **NodeSearchPanel Component** (✅ COMPLETED)
    - v8: `FocusTrapZone` → Tabster focus management system
    - v8: `SearchBox` → v9: `SearchBox` with updated event handlers
    - Location: `/libs/designer/src/lib/ui/panel/nodeSearchPanel/`

Localize/lang/strings.json

@@ -447,6 +447,7 @@
   "6gblzt": "Updated this action",
   "6hj4yW": "Database",
   "6jBzPt": "Enter your question or query here.",
+  "6jJvtY": "Search",
   "6jUopY": "Design Patterns",
   "6jiO7t": "Show run",
   "6jsWn/": "Required. The collection to search within.",
@@ -460,7 +461,6 @@
   "6qPgjN": "Description",
   "6qkBwz": "Required. The number to multiply Multiplicand 2 with.",
   "6rJ+Fj": "Delete workflow graph",
-  "6sEsIN": "Conversational agents",
   "6sGj3J": "Create flow",
   "6sSPNb": "{connectorName} connector",
   "6u6CS+": "Required. The value for which to find the index.",
@@ -733,6 +733,7 @@
   "C3taj3": "Set up your MCP server with existing workflows. Select them from this logic app.",
   "C4NQ1J": "Retrieve items to meet the specified threshold by following the continuation token. Due to connector's page size, the number returned may exceed the threshold.",
   "CAsrZ8": "When an HTTP request is received",
+  "CBQYkl": "Create workflow",
   "CBcl2V": "Logic app name cannot be empty.",
   "CBzSJo": "True",
   "CCpPpu": "Parameters",
@@ -1205,6 +1206,7 @@
   "M6GI6z": "Custom tracking ID",
   "M6U2LE": "The parameters will be saved when the workflow is saved. You can edit it here before save or edit it in the parameter page after save.",
   "M8Aqm4": "Optional. The name of the scoped action where you want the inputs and outputs from the top-level actions inside that scope.",
+  "M9LjqI": "Conversational agents (Preview)",
   "MAX7xS": "Show more",
   "MCzWDc": "Preview",
   "MDbmMw": "Required. The collections to evaluate. An object must be in all collections passed in to appear in the result.",
@@ -1549,6 +1551,7 @@
   "T1TsMb": "Previous",
   "T1q9LE": "Name",
   "T2zwDL": "Custom code configuration",
+  "T6VIym": "Name",
   "T7aD3v": "Secondary key",
   "TBagKD": "No operation selected",
   "TC0zK+": "Model",
@@ -1739,6 +1742,7 @@
   "WToL/O": "Enter a valid condition statement.",
   "WU/tXB": "This session pool in Azure Container Apps is missing the <strong>{roleName}</strong> role.",
   "WUe3DY": "Shorthand for trigger().outputs",
+  "WXclF7": "Workflow created successfully!",
   "WZSmrm": "Please open the panel for details to fix the errors.",
   "Wad3U/": "Create a new App Service plan",
   "WbIGAh": "Succeeded",
@@ -2384,6 +2388,7 @@
   "_6gblzt.comment": "Chatbot changed operation sentence format",
   "_6hj4yW.comment": "Azure Cosmos DB resource label",
   "_6jBzPt.comment": "Chatbot input placeholder text",
+  "_6jJvtY.comment": "Search by run identifier placeholder",
   "_6jUopY.comment": "Design Patterns category",
   "_6jiO7t.comment": "Menu item text for show run",
   "_6jsWn/.comment": "Required collection parameter to apply contains function on",
@@ -2397,7 +2402,6 @@
   "_6qPgjN.comment": "The label for the tool description column",
   "_6qkBwz.comment": "Required number parameter to be multiplied in mul function",
   "_6rJ+Fj.comment": "Title for graph node",
-  "_6sEsIN.comment": "Conversational agent workflow option",
   "_6sGj3J.comment": "Chatbot create a flow text",
   "_6sSPNb.comment": "Alt text on action/trigger card when there is a connector name but no operation name",
   "_6u6CS+.comment": "Required text parameter to search nthIndexOf function with",
@@ -2670,6 +2674,7 @@
   "_C3taj3.comment": "Description for using existing workflows as tools",
   "_C4NQ1J.comment": "description for pagination setting",
   "_CAsrZ8.comment": "Manual trigger category",
+  "_CBQYkl.comment": "Create logic app workflow text.",
   "_CBcl2V.comment": "Logic app name empty text",
   "_CBzSJo.comment": "Short label to represent when a condition is met.",
   "_CCpPpu.comment": "Title for the parameters section",
@@ -3142,6 +3147,7 @@
   "_M6GI6z.comment": "title for client tracking id setting",
   "_M6U2LE.comment": "Text for Info Bar",
   "_M8Aqm4.comment": "Optional string parameter to determine specific actions inside top-level actions",
+  "_M9LjqI.comment": "Conversational agent workflow option",
   "_MAX7xS.comment": "Label for show more text.",
   "_MCzWDc.comment": "Recurrence preview title",
   "_MDbmMw.comment": "Required collection parameters to check intersection function on",
@@ -3486,6 +3492,7 @@
   "_T1TsMb.comment": "Button text for moving to the previous tab in the connection panel",
   "_T1q9LE.comment": "The label for the connector column",
   "_T2zwDL.comment": "Custom code configuration step title",
+  "_T6VIym.comment": "Column header for connection name",
   "_T7aD3v.comment": "Text for secondary access key",
   "_TBagKD.comment": "Message displayed when no operation is selected in the edit operation panel",
   "_TC0zK+.comment": "Label for the Foundry agent model picker",
@@ -3676,6 +3683,7 @@
   "_WToL/O.comment": "Error validation message for invalid condition statement",
   "_WU/tXB.comment": "Message to indicate that the session pool in Azure Container Apps is missing the required role",
   "_WUe3DY.comment": "Label for description of custom triggerOutputs Function",
+  "_WXclF7.comment": "Workflow creation success message",
   "_WZSmrm.comment": "The error description for the workflows tab",
   "_Wad3U/.comment": "Description for the app service plan create popup",
   "_WbIGAh.comment": "The status message to show succeeded in monitoring view.",
@@ -4051,6 +4059,7 @@
   "_dU7f7n.comment": "The type for application insights resource",
   "_dUbKuK.comment": "Chatbot conenction setup skip button text",
   "_dVFyPb.comment": "Parameter Field Default Value Title",
+  "_dVtG1L.comment": "Column header for connection creation time",
   "_daThty.comment": "Button text for proceeding to the next tab",
   "_daoo3l.comment": "Text to show which connection is connected to the node",
   "_ddnfTx.comment": "Aria label for refresh button",
@@ -4461,6 +4470,7 @@
   "_lQNKUB.comment": "Describes connection being added",
   "_lR7V87.comment": "Section header for the functions section",
   "_lSUNx5.comment": "Action Tracking ID text",
+  "_lW2CUD.comment": "Text for workflow label",
   "_lYAlE9.comment": "The tab label for the monitoring parameters tab on the configure template wizard",
   "_lbq5E1.comment": "description of upload content transfer setting",
   "_lciYKh.comment": "Loading message for the MCP server workflows field",
@@ -4527,6 +4537,7 @@
   "_merl0X.comment": "Placeholder for model dropdown",
   "_mfpHrs.comment": "Label for the upload artifacts action",
   "_mgD2ZT.comment": "The tab label for the monitoring parameters tab on the operation panel",
+  "_mjCsxB.comment": "Logic app codeful option",
   "_mjS/k1.comment": "description of suppress woers setting",
   "_mlU+AC.comment": "Header for the connections panel",
   "_mngJaA.comment": "Sort option Z to A",
@@ -4613,6 +4624,7 @@
   "_oChTO9.comment": "Accessibility label for the select workflow row checkbox",
   "_oDHXKh.comment": "Display name for item output",
   "_oFq3ng.comment": "Assertions Panel Title",
+  "_oGINHJ.comment": "Workflow version filter label",
   "_oIRKrF.comment": "Text to show no connections present in the template.",
   "_oJebOR.comment": "Button text displayed while saving authentication settings",
   "_oM6P0z.comment": "Automation category",
@@ -4726,6 +4738,7 @@
   "_qUq/6N.comment": "Text between button name and license link",
   "_qVgQfW.comment": "Search box placeholder text",
   "_qXL3lS.comment": "A project with name already exists message text",
+  "_qZPmZV.comment": "Standard logic app description",
   "_qc5S69.comment": "Label for description of custom length Function",
   "_qiIs4V.comment": "placeholder for retry interval setting",
   "_qif1I+.comment": "Description for the main section",
@@ -5214,6 +5227,7 @@
   "_zViEGr.comment": "Time zone value ",
   "_zWxKLk.comment": "Toggle button label to hide comment section",
   "_zb3lE6.comment": "Chatbot message telling user to set up action in order to save the workflow",
+  "_zbBPqf.comment": "Text for workflow dropdown placeholder",
   "_zcZpHT.comment": "Label for description of custom parseDateTime Function",
   "_zeVnUJ.comment": "Required parameter for value in encodeXmlValue function",
   "_zhMe58.comment": "Label for clear search button",
@@ -5409,6 +5423,7 @@
   "dU7f7n": "Application Insights",
   "dUbKuK": "Skip",
   "dVFyPb": "Default value",
+  "dVtG1L": "Creation time",
   "daThty": "Next",
   "daoo3l": "Connected to {connectionName}.",
   "ddnfTx": "Refresh",
@@ -5819,6 +5834,7 @@
   "lQNKUB": "A line for the parent element is added automatically.",
   "lR7V87": "Functions",
   "lSUNx5": "Action tracking ID",
+  "lW2CUD": "Workflow",
   "lYAlE9": "Parameters",
   "lbq5E1": "Large messages may be split up into smaller requests to the connector to allow large message upload. More details can be found at http://aka.ms/logicapps-chunk#upload-content-in-chunks",
   "lciYKh": "Loading workflows...",
@@ -5885,6 +5901,7 @@
   "merl0X": "Select a model",
   "mfpHrs": "Upload artifacts",
   "mgD2ZT": "Summary",
+  "mjCsxB": "Logic app (codeful)",
   "mjS/k1": "Limit Logic Apps to not include workflow metadata headers in the outgoing request.",
   "mlU+AC": "Connections",
   "mngJaA": "Z to A, descending",
@@ -5971,6 +5988,7 @@
   "oChTO9": "Select workflow row checkbox label",
   "oDHXKh": "Item",
   "oFq3ng": "Assertions",
+  "oGINHJ": "Version",
   "oIRKrF": "No connections in this template",
   "oJebOR": "Saving...",
   "oM6P0z": "Automation",
@@ -6084,6 +6102,7 @@
   "qUq/6N": "you agree to the",
   "qVgQfW": "Search",
   "qXL3lS": "A project with this name already exists in the workspace.",
+  "qZPmZV": "Standard logic app codeful with built-in connectors and triggers",
   "qc5S69": "Returns the number of elements in an array or string",
   "qiIs4V": "Example: {example}",
   "qif1I+": "Build tools for your MCP server by selecting connectors and their actions.",
@@ -6572,6 +6591,7 @@
   "zViEGr": "(UTC+12:00) Petropavlovsk-Kamchatsky - Old",
   "zWxKLk": "Hide description",
   "zb3lE6": "To save this workflow, finish setting up this action:",
+  "zbBPqf": "Select a workflow",
   "zcZpHT": "Converts a string, with optionally a locale and a format to a date",
   "zeVnUJ": "Required. The string to be encoded as a valid XML element value.",
   "zhMe58": "Clear search",

MIGRATION_DEPENDENCY_GRAPH.md

@@ -227,7 +227,7 @@ These patterns can accelerate the remaining designer-ui and designer library mig
 - ✓ **MAJOR**: ReviewList complete architecture migration (GroupedList → Tree) with file removal
 - ✓ Fluent UI v8 → v9 migration patterns established and refined
 - ✓ SVG → Fluent UI icon migration completed for VS Code
-- ✓ **NEW**: NodeSearchPanel migration with Tabster focus management (Branch: ccastrotrejo/panelSearchMigration)
+- ✓ **NEW**: NodeSearchPanel migration with Tabster focus management
 - ✓ Added `tabster: 8.5.6` dependency for advanced accessibility features
 - ✓ Complex component migration patterns validated (Tree, Skeleton components)
 - ⚠️ Performance validation in progress

apps/iframe-app/package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "build": "vite build",
     "dev": "vite",
-    "e2e": "E2E=true vite",
+    "e2e": "vite --mode e2e",
     "preview": "vite preview",
     "test:iframe-app": "vitest run --retry=3",
     "test": "vitest run --retry=3",

apps/iframe-app/vite.config.ts

@@ -61,15 +61,15 @@ function renameIndexHtml(): Plugin {
   };
 }
 
-export default defineConfig(() => {
+export default defineConfig(({ mode }) => {
   const version = getGitVersion();
   return {
     plugins: [
       react(),
       injectBuildVersion(version),
       renameIndexHtml(),
       // Only use mkcert (HTTPS) locally, not in CI or E2E
-      ...(process.env.CI || process.env.E2E ? [] : [mkcert()]),
+      ...(process.env.CI || process.env.E2E || mode === 'e2e' ? [] : [mkcert()]),
     ],
     define: {
       __BUILD_VERSION__: JSON.stringify(`${version.tag}+${version.sha}`),

apps/vs-code-designer/package.json

@@ -30,6 +30,7 @@
     "@types/vscode-webview": "1.57.1",
     "@vscode/extension-telemetry": "^0.9.8",
     "@vscode/test-cli": "^0.0.10",
+    "vscode-languageclient": "^9.0.1",
     "@vscode/test-electron": "^2.5.2",
     "@vscode/vsce": "^3.1.1",
     "adm-zip": "^0.5.10",
@@ -59,7 +60,7 @@
   },
   "private": true,
   "scripts": {
-    "build:extension": "tsup && pnpm run copyFiles",
+    "build:extension": "tsup && pnpm run copyFiles && cd dist && npm install --ignore-scripts",
     "build:ui": "tsup --config tsup.e2e.test.config.ts",
     "copyFiles": "node extension-copy-svgs.js",
     "vscode:designer:pack": "pnpm run vscode:designer:pack:step1 && pnpm run vscode:designer:pack:step2",

apps/vs-code-designer/src/__test__/onboarding.test.ts

@@ -166,7 +166,6 @@ describe('startOnboarding', () => {
     vi.mocked(promptStartDesignTimeOption).mockResolvedValue(undefined);
 
     await startOnboarding(mockContext);
-    await vi.waitFor(() => expect(mockContext.telemetry.measurements.binariesInstallDuration).toBeDefined());
 
     expect(mockContext.telemetry.properties.isDevContainer).toBe('false');
     expect(mockContext.telemetry.properties.lastStep).toBeDefined();
@@ -177,6 +176,28 @@ describe('startOnboarding', () => {
     expect(mockContext.telemetry.measurements.binariesInstallDuration).toBeGreaterThanOrEqual(0);
   });
 
+  it('should wait for dependency onboarding before prompting for design-time startup', async () => {
+    let resolveInstallBinaries = () => {};
+    const installBinariesSpy = vi.spyOn(binaries, 'installBinaries').mockImplementation(
+      () =>
+        new Promise<void>((resolve) => {
+          resolveInstallBinaries = resolve;
+        })
+    );
+    vi.mocked(isDevContainerWorkspace).mockResolvedValue(false);
+    vi.mocked(promptStartDesignTimeOption).mockResolvedValue(undefined);
+
+    const onboardingPromise = startOnboarding(mockContext);
+    await vi.waitFor(() => expect(installBinariesSpy).toHaveBeenCalled());
+
+    expect(promptStartDesignTimeOption).not.toHaveBeenCalled();
+
+    resolveInstallBinaries();
+    await onboardingPromise;
+
+    expect(promptStartDesignTimeOption).toHaveBeenCalledWith(mockContext);
+  });
+
   it('should bypass the auto-start prompt path entirely for devContainer workspaces', async () => {
     vi.mocked(isDevContainerWorkspace).mockResolvedValue(true);
     vi.mocked(scheduleStartAllDesignTimeApis).mockImplementation(() => undefined);