fix: exclude wall battles from remaining faction/meta totals - #184
Merged
Conversation
collectFactionBattles, factionSummaries, factionMemberUnitTrends, traitMatchupMatrix/collectTraitMatchupBattles, metaOverview, and equipSynergy were still counting 【壁戦】 (NPC wall defense) toward battle totals, unlike the other collectors already fixed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectFactionBattles（国の戦績）、factionSummaries（国一覧の戦闘数）、factionMemberUnitTrends（所属武将の使用兵種チップ）、traitMatchupMatrix/collectTraitMatchupBattles（特性別対戦成績）、metaOverview（メタ分析タブ）、equipSynergy（武器×品物の組み合わせ）に、他の集計関数と同じisWallBattle(card)ガードを追加yearBucketWinRankings（年代別ランキング）にも同様のガードを追加し、壁戦の勝敗が年代MVP判定に混ざらないようにしたTest plan
npx tsc --noEmitnpx vitest run（677件、各関数に壁戦除外の回帰テストを追加）npx eslint .npm run build