Fix PHP 8.4 deprecation warnings by adding explicit nullable types - #58
Open
sneakyvv wants to merge 1 commit into
Open
Fix PHP 8.4 deprecation warnings by adding explicit nullable types#58sneakyvv wants to merge 1 commit into
sneakyvv wants to merge 1 commit into
Conversation
PHP 8.4 deprecates implicitly nullable parameters (where a typed parameter has a default value of null without the ? prefix). This adds explicit nullable type declarations to all affected parameters across the codebase, fixes trim() calls on potentially null values, and adds the missing return type to jsonSerialize(). Fixes klaviyo#53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly marking parameters as nullable when they have a default value of null. This change adds explicit ?string and ?Context type declarations to parameters that accept null values, ensuring compatibility with PHP 8.4's stricter type system.
Affected methods:
This addresses issue #53