Skip to content

feat: sync Klaviyo profile language for newsletter recipients - #56

Draft
geannaflavetta wants to merge 3 commits into
klaviyo:master-1.x.xfrom
geannaflavetta:feature/newsletter-profile-language
Draft

feat: sync Klaviyo profile language for newsletter recipients#56
geannaflavetta wants to merge 3 commits into
klaviyo:master-1.x.xfrom
geannaflavetta:feature/newsletter-profile-language

Conversation

@geannaflavetta

@geannaflavetta geannaflavetta commented Apr 28, 2026

Copy link
Copy Markdown

Summary

Syncs properties.language for newsletter recipients using Shopware NewsletterRecipient::getLanguageId() and LocaleCodeProducer, matching registered customer behavior.

Changes

  • Newsletter subscriber CustomerProperties includes locale; Context threaded through translators and subscribeToKlaviyoList.
  • ProfileContactInfo + list normalizers emit attributes.properties.language when locale is resolved.
  • DI: LocaleCodeProducer on newsletter translators (gateway_services.xml).

Notes

  • Please verify Klaviyo bulk profile-subscription jobs accept nested properties.language in staging.
  • Planning notes are not part of this PR; they stay on the author’s machine only.

How to test

  • Storefront newsletter signup + subscriber sync job; confirm language on Klaviyo profile.

Made with Cursor

- Resolve locale from NewsletterRecipient language_id via LocaleCodeProducer
- Thread Context through subscribeToKlaviyoList and newsletter translators
- ProfileContactInfo + list normalizers emit properties.language
- Composer lint:php:newsletter-language script
- gitignore docs/plans for local handoff notes

Made-with: Cursor
@geannaflavetta
geannaflavetta marked this pull request as ready for review April 28, 2026 15:11
Comment thread src/Klaviyo/Gateway/KlaviyoGateway.php Outdated
Comment thread .gitignore Outdated
Comment thread src/Klaviyo/Gateway/Translator/NewsletterSubscriberPropertiesTranslator.php Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit cb0c9e5. Configure here.

Comment thread docs/plans/newsletter-language-sync.md Outdated
@geannaflavetta
geannaflavetta marked this pull request as draft April 28, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant