fix: open sqlite inputs read-only - #64
Merged
Merged
Conversation
rusqlite default flags include SQLITE_OPEN_CREATE, so reading a mistyped path left a freshly created empty database behind (found when a failed ocel-studio connector run polluted its workspace). Inputs now open with SQLITE_OPEN_READ_ONLY; writes keep CREATE. Closes #63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Reading a mistyped sqlite path created an empty database (rusqlite default flags include SQLITE_OPEN_CREATE) — found when a failed ocel-studio connector run left a 0-byte file that then broke the studio startup pick. Inputs now open with SQLITE_OPEN_READ_ONLY | NO_MUTEX; the write path keeps CREATE. Regression test asserts the missing-file read errors without creating anything.
🤖 Generated with Claude Code