Skip to content

fix(usps): declare usps_rate_indicator option and price_type connection config #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zggit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(usps): declare usps_rate_indicator option and price_type connection config #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/connectors/usps/karrio/providers/usps/shipment/create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ def shipment_request(
width=package.width.IN,
girth=package.girth.value,
mailClass=mail_class,
rateIndicator=package.options.usps_rate_indicator.state or "DR",
rateIndicator=package.options.usps_rate_indicator.state or "SP",
processingCategory=lib.identity(
package.options.usps_processing_category.state or "NON_MACHINABLE"
),
Expand Down
1 change: 1 addition & 0 deletions modules/connectors/usps/karrio/providers/usps/units.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ class ShippingOption(lib.Enum):
usps_carrier_release = lib.OptionEnum("carrierRelease", bool, meta=dict(category="DELIVERY_OPTIONS"))
usps_physical_signature_required = lib.OptionEnum("physicalSignatureRequired", bool, meta=dict(category="SIGNATURE"))
usps_price_type = lib.OptionEnum("priceType", lib.units.create_enum("priceType", ["RETAIL", "COMMERCIAL", "CONTRACT"]))
usps_rate_indicator = lib.OptionEnum("rateIndicator")
usps_destination_entry_facility_type = lib.OptionEnum("destinationEntryFacilityType", lib.units.create_enum("destinationEntryFacilityType", ["NONE", "DESTINATION_NETWORK_DISTRIBUTION_CENTER", "DESTINATION_SECTIONAL_CENTER_FACILITY", "DESTINATION_DELIVERY_UNIT", "DESTINATION_SERVICE_HUB"]))
usps_extra_services = lib.OptionEnum("extraServices", list)
usps_shipping_filter = lib.OptionEnum("shippingFilter", lib.units.create_enum("shippingFilter", ["PRICE", "SERVICE_STANDARDS"]))
Expand Down
1 change: 1 addition & 0 deletions modules/connectors/usps/karrio/providers/usps/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def connection_config(self) -> lib.units.Options:

class ConnectionConfig(lib.Enum):
permit_ZIP = lib.OptionEnum("permit_ZIP")
price_type = lib.OptionEnum("price_type")
permit_number = lib.OptionEnum("permit_number")
shipping_options = lib.OptionEnum("shipping_options", list)
shipping_services = lib.OptionEnum("shipping_services", list)
Expand Down
2 changes: 1 addition & 1 deletion modules/connectors/usps/tests/usps/test_shipment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def test_parse_shipment_response_sample2(self):
"mailClass": "LIBRARY_MAIL",
"mailingDate": "2024-07-28",
"processingCategory": "NON_MACHINABLE",
"rateIndicator": "DR",
"rateIndicator": "SP",
"weight": 44.1,
"weightUOM": "lb",
"width": 4.72,
Expand Down