Skip to content

upgrade to SQLAlchemy version 2 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M4rque2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade to SQLAlchemy version 2 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dataset/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ def begin(self):
"""
if not hasattr(self.local, "tx"):
self.local.tx = []
if self.executable.in_transaction():
self.executable.commit()
self.local.tx.append(self.executable.begin())

def commit(self):
Expand Down
5 changes: 5 additions & 0 deletions dataset/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ def insert(self, row, ensure=None, types=None):
"""
row = self._sync_columns(row, ensure, types=types)
res = self.db.executable.execute(self.table.insert(), row)
# SQLAlchemy 2.0.0b1 removes auto commit
if hasattr(self.db.local, "tx") and self.db.local.tx:
pass
else:
self.db.executable.commit()
if len(res.inserted_primary_key) > 0:
return res.inserted_primary_key[0]
return True
Expand Down