-
Notifications
You must be signed in to change notification settings - Fork 50
Add navbar icon support via new config item #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /** | ||
| * Navbar icon links for social media and external resources. | ||
| * Configured via site.options.navbar_icons in myst.yml. | ||
| */ | ||
| import type { NavbarIcon } from '@myst-theme/common'; | ||
| import { | ||
| GithubIcon, | ||
| XIcon, | ||
| BlueskyIcon, | ||
| DiscordIcon, | ||
| MastodonIcon, | ||
| LinkedinIcon, | ||
| YoutubeIcon, | ||
| SlackIcon, | ||
| EmailIcon, | ||
| WebsiteIcon, | ||
| } from '@scienceicons/react/24/solid'; | ||
| import { RssIcon } from '@heroicons/react/24/solid'; | ||
|
|
||
| // Maps icon name strings to icon components | ||
| const ICON_MAP: Record<string, React.ComponentType<{ className?: string }>> = { | ||
| github: GithubIcon, | ||
| twitter: XIcon, | ||
| x: XIcon, | ||
| bluesky: BlueskyIcon, | ||
| discord: DiscordIcon, | ||
| mastodon: MastodonIcon, | ||
| linkedin: LinkedinIcon, | ||
| youtube: YoutubeIcon, | ||
| slack: SlackIcon, | ||
| email: EmailIcon, | ||
| rss: RssIcon, | ||
| link: WebsiteIcon, | ||
| website: WebsiteIcon, | ||
| }; | ||
|
|
||
| // Default tooltip text for each icon type | ||
| const DEFAULT_TITLES: Record<string, string> = { | ||
| github: 'GitHub', | ||
| twitter: 'X (Twitter)', | ||
| x: 'X (Twitter)', | ||
| bluesky: 'Bluesky', | ||
| discord: 'Discord', | ||
| mastodon: 'Mastodon', | ||
| linkedin: 'LinkedIn', | ||
| youtube: 'YouTube', | ||
| slack: 'Slack', | ||
| email: 'Email', | ||
| rss: 'RSS Feed', | ||
| link: 'Website', | ||
| website: 'Website', | ||
| }; | ||
|
|
||
| /** Single icon link that opens in a new tab */ | ||
| export function NavbarIconLink({ icon, url, title }: NavbarIcon) { | ||
| const IconComponent = ICON_MAP[icon.toLowerCase()] ?? WebsiteIcon; | ||
| const displayTitle = title ?? DEFAULT_TITLES[icon.toLowerCase()] ?? icon; | ||
|
|
||
| return ( | ||
| <a | ||
| href={url} | ||
| title={displayTitle} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="myst-navbar-icon inline-flex items-center justify-center p-2 text-stone-600 dark:text-stone-300 hover:text-stone-900 dark:hover:text-white transition-colors" | ||
| > | ||
| <IconComponent className="w-5 h-5" /> | ||
| <span className="sr-only">{displayTitle}</span> | ||
| </a> | ||
| ); | ||
| } | ||
|
|
||
| /** Container for multiple navbar icon links */ | ||
| export function NavbarIcons({ icons, className }: { icons?: NavbarIcon[]; className?: string }) { | ||
| if (!icons || icons.length === 0) return null; | ||
|
|
||
| return ( | ||
| <div className={`myst-navbar-icons flex items-center ${className ?? ''}`}> | ||
| {icons.map((iconConfig, index) => ( | ||
| <NavbarIconLink key={iconConfig.url || index} {...iconConfig} /> | ||
| ))} | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have a type array?
Similar to the
navthis is a special property that this PR is introducing across all site themes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think this part needs to be changed to object or something - I haven't put any cycles in this since my original push because it's not clear to me if folks want to make a deeper change in mystmd first and it's blocking this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think this part needs to be changed to object or something - I haven't put any cycles in this since my original push because it's not clear to me if folks want to make a deeper change in mystmd first and it's blocking this