Override undici to 8.1.0#196
Conversation
undici to 8.1.0
5830300 to
f240c37
Compare
|
@MichaelHatherly What do you think of this PR? Pros and cons of overriding
Pros and cons of staying on the current version (
|
|
I don't think that we should be doing this override. Are there specific known vulnerabilities that affect us here? My take is that we just let upstream upgrade their deps as an when they do. |
You can see the CodeQL warnings here: https://github.com/julia-actions/install-juliaup/security/code-scanning |
Maybe upstream would accept a patch? If it's not being worked on already? |
The upstream repo (https://github.com/actions/toolkit) has several open issues and PRs, including:
Regarding whether upstream would accept a PR from us, the repo's README says:
|
Co-authored-by: OpenAI Codex [GPT-5] <codex@openai.com>
f240c37 to
f071ba2
Compare
Related Issue
Related to #193 (but doesn't close it, because this PR just does an NPM override).
Summary
undiciresolutions use8.1.0package-lock.jsonso the resolved tarball and engine metadata point atundici@8.1.0dist/index.cjsso the checked-in action bundle matches the updated dependency graphWhy
undiciis not a direct dependency in this repo. It is pulled in transitively by@actions/githuband@actions/http-client, and the currently published@actions/*packages still depend on the6.xline. This change moves the repo to the latest npm release ofundicinow instead of waiting for upstream package updates.One Thing To Be Aware Of
This PR relies on an npm override because upstream
@actions/*packages still declareundici^6.23.0. The repo runs onnode24, soundici@8.1.0is engine-compatible here, but the key review point is that we are intentionally overriding transitive dependency ranges rather than getting this version through a normal upstream semver update.Validation
npm run lintmake buildmake packnpm ls undici --all🤖 Generated by OpenAI Codex.