Use case using default config for alpha release - #93
Conversation
|
Not sure why this error started popping up: "RemoveError: 'setuptools' is a dependency of conda and cannot be removed from Saw same error on @jlhitt1993 's latest PR. |
|
I have fixed the setuptools error with a workaround. It is some problem with conda that I couldn't find a complete fix for, but the builds should work now for the time being. |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 70.95% 72.34% +1.38%
==========================================
Files 8 8
Lines 210 282 +72
==========================================
+ Hits 149 204 +55
- Misses 61 78 +17
Continue to review full report at Codecov.
|
jlhitt1993
left a comment
jlhitt1993
left a comment
There was a problem hiding this comment.
I think you should break up lines 2 and 15 so they are less than 100 characters for readability.
| 1. After running experiment, pytentiostat promopts "Would you like to save the data? [y/n]". | ||
| 1. GS types y. | ||
| 1. Pytentiostat saves the data to their desktop. | ||
| 1. Pytentiostat prompts if user wants to run another experiment. | ||
| 1. GS types n. |
There was a problem hiding this comment.
Latest version automatically saves without asking. First prompt is "Would you like to repeat the last experiment? [y/n]"
| 1. Pyentiostat prompts "Press enter to connect to a JUAMI potentiostat.". | ||
| 1. GS presses enter. | ||
| 1. Pytentiostat prints to console "Searching for potentiostat...". | ||
| 1. Pyentiostat prints to console "Pytentiostat connected COM. Reading configuration file...". |
There was a problem hiding this comment.
The part "Reading configuration file..." has been removed.
There was a problem hiding this comment.
good. Less chatter is always better.
|
|
||
| ### Program Setup: | ||
| 1. GS copies the default example config file to an easy to navigate to directory (WD). | ||
| 1. GS opens up a console window. |
There was a problem hiding this comment.
I might change "console window" to "command line/terminal" to sound more familiar.
|
|
||
| ### Before Installation: | ||
| 1. Member of dev team gives GS a JUAMI Potentiostat with a 1kOhm resistor. | ||
| 1. GS installs python on their computer. |
There was a problem hiding this comment.
I think you should change python to miniconda to be more specific.
There was a problem hiding this comment.
I agree. python and miniconda are different. Let's make instructions that can be followed step by step. There should probably be a pre-step that asks the user to check their system to see if miniconda or Anaconda is installed. They could just open a terminal and type "conda" for example.
We have to decide whether we want to make them use the miniconda command prompt. It changes how they do the installation. There are arguments for doing it either way so I am not sure....we could discuss more on a call.
|
Thanks for the feedback, added the recommendations. Yeah, let's discuss instillation when we get started back up again. |
|
is this wanted? We can work to merge it or we can close it. |
4 participants
This is a use case for a simple operation of the pytentiostat that should be satisfied by the program upon alpha release. This PR also sets up a directory for future use cases in examples/dev/.