fix(): globalAlpha, transform, setTransform - #24
Closed
ShaMan123 wants to merge 1 commit into
Closed
Conversation
Owner
|
Code has been modernized-please feel free to open a new pull request. Also, please note that the goals of canvas2pdf and node canvas are different-canvas2pdf is a browser solution whereas node canvas required node. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports ApryseSDK#1
Fixes
globalAlphagetter was retuning a ref to the doc - fixed that by keeping it in state.Implemented
transform,setTransform.Misc
IMO you should merge fixes from https://github.com/PDFTron/canvas2pdf
Stuff like es6 doesn't work here but work there etc. (importing means you must declare PDFDocument on the global object for the lib to work)
As I wrote I am going for node canvas pdf options which are very robust