Require PHP 8.1 and Upgrade to PHPUnit 10 - #47
Open
GromNaN wants to merge 9 commits into
Open
Conversation
jmikola
reviewed
Oct 15, 2025
jmikola
reviewed
Jan 12, 2026
| use GeoJson\CoordinateReferenceSystem\Linked; | ||
| use GeoJson\Exception\UnserializationException; | ||
| use PHPUnit\Framework\Attributes\DataProvider; | ||
| use PHPUnit\Framework\Attributes\Group; |
Owner
There was a problem hiding this comment.
Is Group actually needed for anything? Likewise in the other test files, as I see it was added but not referenced.
Author
There was a problem hiding this comment.
Indeed, they were there before I removed the attributes, so I deleted the unnecessary use statements. I tried using SlevomatCodingStandard.Namespaces.UnusedUses, but it also removes use statements that correspond to PHPdoc types.
PHPCS <rule ref=SlevomatCodingStandard.Namespaces.UnusedUses /> is too agressive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.