Skip to content

Require installation of nodejs_dependencies before running the test targ... - #2

Open
ctavan wants to merge 1 commit into
jeremybarnes:masterfrom
ctavan:install-node-deps-before-test
Open

Require installation of nodejs_dependencies before running the test targ...#2
ctavan wants to merge 1 commit into
jeremybarnes:masterfrom
ctavan:install-node-deps-before-test

Conversation

@ctavan

@ctavan ctavan commented Jul 17, 2013

Copy link
Copy Markdown

It's currently not very intuitive that one has to run make nodejs_dependencies manually before running make test... This patch should fix it.

@RAttab

RAttab commented Sep 5, 2013

Copy link
Copy Markdown
Contributor

I'm not a fan of this change because for two reasons.

First, make dependencies also includes python_dependencies which is not useful when building node programs (this is easily fixed).

Next, nodejs_dependencies always calls npm even if there's nothing to do which I dislike quite a bit. I don't think there's an easy way to only call npm when dependencies need updating (not too familiar with npm so I may be wrong). Generally speaking, if there is nothing to build or test make should return without doing anything.

Finally, nodejs_dependencies is in the build instruction and only needs to be invoked once so requiring that it be called every time you want to execute a single test is a bit overkill.

nicolaskruchten added a commit that referenced this pull request Nov 29, 2014
TRIVIAL adding dep to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants