Require installation of nodejs_dependencies before running the test targ... - #2
Open
ctavan wants to merge 1 commit into
Open
Require installation of nodejs_dependencies before running the test targ...#2ctavan wants to merge 1 commit into
ctavan wants to merge 1 commit into
Conversation
Contributor
|
I'm not a fan of this change because for two reasons. First, make dependencies also includes python_dependencies which is not useful when building node programs (this is easily fixed). Next, nodejs_dependencies always calls npm even if there's nothing to do which I dislike quite a bit. I don't think there's an easy way to only call npm when dependencies need updating (not too familiar with npm so I may be wrong). Generally speaking, if there is nothing to build or test make should return without doing anything. Finally, nodejs_dependencies is in the build instruction and only needs to be invoked once so requiring that it be called every time you want to execute a single test is a bit overkill. |
nicolaskruchten
added a commit
that referenced
this pull request
Nov 29, 2014
TRIVIAL adding dep to docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently not very intuitive that one has to run
make nodejs_dependenciesmanually before runningmake test... This patch should fix it.