Skip to content

Modernization - #47

Open
gounthar wants to merge 10 commits into
jenkinsci:masterfrom
gounthar:refactor/jenkins-plugin-updates
Open

Modernization#47
gounthar wants to merge 10 commits into
jenkinsci:masterfrom
gounthar:refactor/jenkins-plugin-updates

Conversation

@gounthar

Copy link
Copy Markdown

Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/qNxoSNwmk?organizationId=SmVua2lucyBDSQ%3D%3D

I propose in this PR an update of the Jenkins version, BOM version and the use of more modern annotations.

Testing done

Builds on Linux/JDK21.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar
gounthar marked this pull request as ready for review October 31, 2023 12:29
@gounthar

Copy link
Copy Markdown
Author

Could someone please replay this build with the modified Jenkinsfile?
This PR build has run with JDK8, and this PR makes the plugin only compatible with JDK11+.
Thanks.

@toneill818

Copy link
Copy Markdown

Is this plugin still maintained?

@panicking

Copy link
Copy Markdown

@gounthar I will ask to mantein it to apply modernization

@gounthar

Copy link
Copy Markdown
Author

Thanks, @panicking !
We can do much better now with the latest version of the plugin modernizer tool.
We can close this PR.

@panicking

Copy link
Copy Markdown

Thanks, @panicking ! We can do much better now with the latest version of the plugin modernizer tool. We can close this PR.

I have already prepared some patches on top of it with Junit migration and java25 and java21 support. I'm going to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants