Add build safety warnings, drop personal references, remove em-dashes#1
Draft
jayzuccarelli wants to merge 3 commits into
Draft
Add build safety warnings, drop personal references, remove em-dashes#1jayzuccarelli wants to merge 3 commits into
jayzuccarelli wants to merge 3 commits into
Conversation
Pre-announce pass. The history rewrite landed separately on main; this is the working-tree half. Safety. BUILD.md walks a self-described beginner through plugging a mains air pump in beside an open bucket of water (G1) and hand-dosing pH-Down (H4) with no protective guidance anywhere. Grepping the repo for gfci, rcd, goggles, gloves, corrosive, or ventilat returned zero hits: every existing use of "safety" refers to the agent's dose caps, not the human's. Added a Safety section at the top of BUILD.md covering GFCI/RCD outlets, drip loops, gloves and eye protection for acid handling, and solder ventilation, plus inline pointers at the two steps that actually carry the risk. The reflex tier bounds the software; it cannot bound wiring or chemistry, and the docs now say so. Personal references. "Escalate to Jay" shipped inside the model-visible tool schema in agent.py; a prior pass fixed the copy in tools.py but missed this one. Also neutralized schema.py and instance/prompt.md. BUILD.md flashed from ~/projects/eden/..., an absolute path from my machine that contradicted docs/hardware.md's correct relative form. Em-dashes: 151 removed. Colons after headings and bold labels, commas mid-sentence. Audited the result for punctuation artifacts and hand-fixed the one wrapped line that came out wrong. make check green: ruff, mypy (12 files), 10 passed.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
docs/hardware.md's pin table used an em-dash as the *value* of the 'XIAO pin' cell for the pH analog input, meaning 'no pin, it goes through the ADS1115'. The sweep turned it into a comma, leaving '| pH analog in |, |'. Now '*(none)*', matching how the air-pump row already expresses the same thing. Found by auditing every swept repo for this bug class. make check still green.
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
Owner
Author
|
@coderabbitai full review |
✅ Action performedFull review finished. Your plan includes PR reviews subject to rate limits. More reviews will be available in 53 minutes. |
Review of this branch turned up three things the safety section claimed to cover and did not. No check valve. The air pump sits beside the bucket, below the water line, so when it stops water siphons back down the hose into a mains-powered housing. That is the specific form the mains-near-water hazard takes in this build, and neither the safety section nor step G1 mentioned it. No exposure response. The section said to wear gloves and eye protection and then went quiet about what to do when pH-Down reaches skin or an eye. No instruction to wire unpowered. Components C and D have you screwing bare conductors into terminals, and a later step reads as though the brick was already meant to be unplugged, but nothing ever said so. Also softened the opening claim. 'None of that is dangerous if you take four precautions' is not true of mains near water or of concentrated phosphoric acid; precautions manage those risks rather than removing them. The section was also unreachable: README never linked BUILD.md, and its one hardware pointer landed on a section headed Safety that is entirely about software dose caps. README now links BUILD.md and says why, and that heading says which kind of safety it means. Two escape hatches told the reader to 'tell me' when the dose cap fails to fire or the MOSFET runs hot. A public reader has no me, and those are the two moments that most need an instruction, so both now say what to do. Remaining sweep artifacts: a double colon in the model-visible system prompt, a dangling colon in the firmware header, a display_name that read as a list, a CLI comma splice, and the last two em-dashes in Makefile and .gitignore. Repo-wide count is now zero. The SIM102 pragma had picked up a comma where ruff expects a code separator; it still suppressed, but only because ruff ignores trailing text. Rationale moved off the pragma line. make check green: ruff, mypy on 12 files, 10 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-announce verification pass. The history rewrite already landed on main (see below); this PR is the working-tree half.
Safety, the one that would dominate an HN thread
BUILD.md is explicitly pitched at beginners ("a tiny board about the size of your thumbnail") and walks them through:
Grepping the whole repo for
gfci|rcd|mains|goggles|gloves|corrosive|ventilat|child|petreturned zero hits. Every existing use of the word "safety" in the docs refers to the agent's dose caps, not the human's wellbeing.docs/hardware.md:83is literally titled "Safety, the reflex tier, in firmware (not the agent)."Added a Safety section at the top of BUILD.md (GFCI/RCD outlets, drip loops, gloves and eye protection, add-acid-to-water, store away from children and pets, solder ventilation), plus short inline pointers at G1 and H4 so the warning appears where the risk is, not only at the top.
Hydroponics posts draw electrical and chemical scrutiny reliably. This is cheap insurance and, honestly, correct regardless of the announcement.
Personal references
eden/gardener/agent.py:96shipped"Escalate to Jay (severity: ...)"inside the model-visible tool schema. A prior pass fixed the same copy intools.pybut missed this one. Also neutralizededen/schema.py:8andinstance/prompt.md.BUILD.md:85flashed from~/projects/eden/esphome/eden-z1.yaml, an absolute path from my machine, contradictingdocs/hardware.md:99which correctly uses the relative form.Em-dashes
151 removed. Colons after headings and bold labels, commas mid-sentence. I audited the output for punctuation artifacts afterwards and hand-fixed the one wrapped line that came out as
, not a re-plumb.Verification
make checkgreen: ruff, mypy across 12 source files, 10 passed.Separately: main was rewritten and force-pushed
Commit
3b7803dpublicly carried:That disclosed the employer relationship and an internal approval process, and named two sibling projects under the same gate. Rewritten with
git filter-repo, along with historical references to thevaiohost, the privatehomeopsrepo,LINEAR_TASKS.md, andJAY-NNtracker IDs.Done at zero risk: 0 forks, 0 stars, 0 watchers, no open PRs, single branch. Verified against a fresh clone that all target strings return 0 hits. Legitimate Amazon ASIN product links in
docs/hardware.mdwere preserved. A pre-rewrite bundle was saved locally before the force-push.