Skip to content

properties tab select between manual and eq ids#160

Open
ioan-alexandra wants to merge 9 commits into
developfrom
ux/properties_tab_select_between_manual_and_eq_ids
Open

properties tab select between manual and eq ids#160
ioan-alexandra wants to merge 9 commits into
developfrom
ux/properties_tab_select_between_manual_and_eq_ids

Conversation

@ioan-alexandra

Copy link
Copy Markdown
Collaborator

fixes #153

image

@ioan-alexandra ioan-alexandra requested a review from SBlokhuizen May 5, 2026 15:10
@ioan-alexandra ioan-alexandra self-assigned this May 5, 2026
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
ioan-alexandra and others added 3 commits May 19, 2026 11:21
Remove 'nice' from norecursedirs in pytest options.
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
@ioan-alexandra ioan-alexandra marked this pull request as ready for review June 1, 2026 08:08

@maarten-ic maarten-ic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI improvement looks good! Some small comments below, and let's review the architecture: I think the code will be a lot cleaner if the data loading is done "locally" on the viewer classes.

Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Comment thread waveform_editor/gui/shape_editor/plasma_properties.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In properties tab allow user to select between manual and Eq IDS for the input

3 participants