Skip to content

Ux/use tabs instead of accordions#159

Draft
ioan-alexandra wants to merge 5 commits into
iterorganization:developfrom
ioan-alexandra:ux/use_tabs_instead_of_accordions
Draft

Ux/use tabs instead of accordions#159
ioan-alexandra wants to merge 5 commits into
iterorganization:developfrom
ioan-alexandra:ux/use_tabs_instead_of_accordions

Conversation

@ioan-alexandra

@ioan-alexandra ioan-alexandra commented May 5, 2026

Copy link
Copy Markdown
Collaborator

fixes #150

image

@ioan-alexandra ioan-alexandra requested a review from SBlokhuizen May 5, 2026 10:35
@ioan-alexandra ioan-alexandra self-assigned this May 5, 2026
Comment thread waveform_editor/gui/shape_editor/shape_editor.py
Comment thread waveform_editor/gui/shape_editor/shape_editor.py Outdated
Comment thread waveform_editor/gui/shape_editor/shape_editor.py

@SBlokhuizen SBlokhuizen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SBlokhuizen SBlokhuizen marked this pull request as ready for review May 20, 2026 08:05

@maarten-ic maarten-ic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! See comments below, and let me know if you'd like to discuss:

Comment thread waveform_editor/gui/shape_editor/shape_editor.py Outdated
Comment thread waveform_editor/gui/shape_editor/shape_editor.py Outdated
@ioan-alexandra

ioan-alexandra commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

right now there isnt enough space on smaller screens for this approach. it would be best to fix the responsiveness of the graph on the left before this is merged, as its size right now shrinks and pushes the tabs too much

image

@ioan-alexandra ioan-alexandra marked this pull request as draft June 1, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change from Accordion to Tabs for the PSE menu options

3 participants