docker-update: update node versions, npm packages, fix and improve docker testing setup#25
Open
Louwrensth wants to merge 10 commits into
Open
docker-update: update node versions, npm packages, fix and improve docker testing setup#25Louwrensth wants to merge 10 commits into
Louwrensth wants to merge 10 commits into
Conversation
add script/update-npm.sh
- node + nginx instead of python/gunicorn - run nginx at container-host:8080 - serve static js app at :8080/dashboard/ - inject container-host:5000 as server in runtime-config.js - inject git-describe in .app-version as fallback - map :8080/api/v1.2 -> container-host:5000/v1.2
Louwrensth
force-pushed
the
feature/docker-update
branch
from
e5fccc4 to
fe57701
Compare
Louwrensth
requested review from
SimonPinches,
olivhoenen and
prasad-sawantdesai
as code owners
Louwrensth
changed the title
obsoletes update-npm.sh script
…building add artifacts for testing, static dist/app and service image adjust for buildx caching in GHA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${{ matrix.node-version }}in its scope.