Skip to content

Added list json control into the TypeRegistry fromJson method. #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
E-MRE wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added list json control into the TypeRegistry fromJson method. #1294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b92ad19
Added list json control into the TypeRegistry fromJson method.
E-MRE Jun 7, 2024
782e43d
fromJson method parameters value changed with dynamic
E-MRE Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/src/impl/type_registry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class _TypeRegistry {
'Type is not registered. Did you forget to register it?',
);
}
if (json is Map<String, dynamic>) {
if (json is Map<String, dynamic> || json is List) {
value = handler.fromJson(json);
} else {
throw ArgumentError('Type mismatch. Expected Map<String,dynamic> '
Expand Down Expand Up @@ -72,7 +72,7 @@ class _TypeRegistry {
}
}

T? _noop<T>(Map<String, dynamic> json) {
T? _noop<T>(dynamic json) {
throw UnimplementedError();
}

Expand All @@ -85,7 +85,7 @@ class _TypeHandler<T> {

final int? typeId;

final T? Function(Map<String, dynamic> json) fromJson;
final T? Function(dynamic json) fromJson;

bool handlesValue(dynamic value) {
return value is T;
Expand Down