Probe for matching torch version, not just live URL - #1185
Merged
willghatch merged 2 commits intoMar 25, 2026
Conversation
The gen-pytorch-rocm-requirements.py script was selecting the first wheel source whose URL responded to an HTTP HEAD, without checking whether it actually contained a torch version matching the spec. When the PyTorch Foundation rocm7.2 index only carries torch>=2.11 but TORCH_SPEC requires <2.9, the install silently failed and fell back to a CUDA build from PyPI. Replace the HTTP HEAD probe with one that fetches the package listing and verifies a matching torch wheel exists before selecting a source. This lets the script correctly fall through to the AMD --find-links repo when the PyTorch index lacks a compatible version. Signed-off-by: William G Hatch <william@hatch.uno>
ftynse
approved these changes
Mar 25, 2026
Signed-off-by: William G Hatch <william@hatch.uno>
willghatch
force-pushed
the
users/willghatch/gen-pytorch-requirements-probe-better
branch
from
March 25, 2026 15:10
9bbb7ca to
91e0864
Compare
willghatch
deleted the
users/willghatch/gen-pytorch-requirements-probe-better
branch
March 25, 2026 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gen-pytorch-rocm-requirements.py script was selecting the first wheel source whose URL responded to an HTTP HEAD, without checking whether it actually contained a torch version matching the spec. When the PyTorch Foundation rocm7.2 index only carries torch>=2.11 but TORCH_SPEC requires <2.9, the install silently failed and fell back to a CUDA build from PyPI.
Replace the HTTP HEAD probe with one that fetches the package listing and verifies a matching torch wheel exists before selecting a source. This lets the script correctly fall through to the AMD --find-links repo when the PyTorch index lacks a compatible version.