Skip to content

crypto: Trivial reuse of computed values in pairing helpers #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chfast merged 1 commit into from
May 26, 2026
Merged

crypto: Trivial reuse of computed values in pairing helpers #1542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/evmone_precompiles/pairing/bn254/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,11 +403,11 @@ constexpr ecc::JacPoint<Fq2> lin_func_and_dbl(
const auto V = x0 * H_squared;

const auto X3 = R_squared - H_cubed - (V + V);
const auto Y3 = R * (x0 * H_squared - X3) - y0 * H_cubed;
const auto Y3 = R * (V - X3) - y0 * H_cubed;
const auto Z3 = H * z0;

t[0] = (z0 * z0_squared * x0 - U2 * z0_cubed);
t[1] = (S2 * z0_squared - y0 * z0_squared);
t[0] = z0_cubed * x0 - U2 * z0_cubed;
t[1] = S2 * z0_squared - y0 * z0_squared;
Comment on lines +409 to +410
t[2] = y0 * U2 - x0 * S2;

return ecc::JacPoint<Fq2>{X3, Y3, Z3};
Expand All @@ -432,8 +432,8 @@ constexpr void lin_func(
const auto U2 = x1 * z0_squared;
const auto S2 = y1 * z0_cubed;

t[0] = (z0 * z0_squared * x0 - U2 * z0_cubed);
t[1] = (S2 * z0_squared - y0 * z0_squared);
t[0] = z0_cubed * x0 - U2 * z0_cubed;
t[1] = S2 * z0_squared - y0 * z0_squared;
Comment on lines +435 to +436
t[2] = y0 * U2 - x0 * S2;
}

Expand Down