Skip to content

fix(cloud_proxy): harden parsing and async proxy error handling #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkralik wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(cloud_proxy): harden parsing and async proxy error handling #665

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aefeb90
fix(cloud_proxy): harden parsing and async proxy error handling
jkralik Apr 9, 2026
12c803c
test: make enum comparison type-safe and apply style cleanups
jkralik Apr 9, 2026
ab3bd74
fix(cloud_proxy): rename url_size to url_len and clarify it's string …
Copilot Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/unittest/discovery/discovery.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#include <string>
#include <vector>
#include <unordered_map>
#include <algorithm>

namespace oc::discovery {

Expand Down
9 changes: 7 additions & 2 deletions api/unittest/enumstest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,13 @@
TEST(TestEnums, OCEnum)
{
EXPECT_EQ(nullptr, oc_enum_to_str(static_cast<oc_enum_t>(0)));
if constexpr (static_cast<oc_enum_t>(std::numeric_limits<int>::max()) >
OC_ENUM_ZIGZAG) {
using oc_enum_ut = std::underlying_type_t<oc_enum_t>;
constexpr auto zigzag_v = static_cast<oc_enum_ut>(OC_ENUM_ZIGZAG);
constexpr auto int_max_v = static_cast<std::make_unsigned_t<oc_enum_ut>>(
std::numeric_limits<int>::max());

if constexpr (int_max_v >
static_cast<std::make_unsigned_t<oc_enum_ut>>(zigzag_v)) {
EXPECT_EQ(nullptr, oc_enum_to_str(static_cast<oc_enum_t>(
std::numeric_limits<int>::max())));
}
Expand Down
Loading
Loading