Skip to content

fix(i18n): replace "(s)" parenthetical plurals flagged by Weblate#9179

Open
lstein wants to merge 1 commit into
mainfrom
lstein/bug/weblate-dup-strings
Open

fix(i18n): replace "(s)" parenthetical plurals flagged by Weblate#9179
lstein wants to merge 1 commit into
mainfrom
lstein/bug/weblate-dup-strings

Conversation

@lstein
Copy link
Copy Markdown
Collaborator

@lstein lstein commented May 15, 2026

Summary

  • Hosted Weblate flagged 11 strings in en.json for the plural-form check because they used the word(s) parenthetical idiom — a construct that can't be translated cleanly into languages with multiple plural categories (Russian, Arabic, Polish, etc.).
  • 5 static UI strings (Upload Image(s), Enter hotkey(s)…, model file(s), Incompatible LoRA(s) added, raster layer(s)) rephrased to plain plural form.
  • 6 count-driven strings (bulk delete / reidentify confirmations and toasts) split into proper i18next _one / _other key pairs. Every call site already passes count: …, so no .ts / .tsx changes were needed — i18next picks the correct form automatically.

Notes

  • The _one form of reidentifyModelsConfirm was also corrected from …re-probe their weights files… to …re-probe its weights file… so the singular grammar reads naturally.
  • Other locales (de.json, etc.) are unaffected at runtime — i18next falls back to en.json for missing keys, and translators will pick up the new key shape on the next Weblate sync.

Test plan

  • Verify Bulk Delete confirmation reads correctly for 1 model vs. N models.
  • Verify Bulk Reidentify confirmation reads correctly for 1 model vs. N models (note grammar shift on weights file/files).
  • Verify the post-action toasts (modelsDeleted, someModelsFailedToDelete, modelsReidentified, someModelsFailedToReidentify) render the right singular/plural form.
  • Confirm the hotkey input placeholder, multi-upload button tooltip, inplace-install description, incompatible-LoRA warning, and denoising-strength tooltip all render without (s).
  • Confirm Weblate's plural-form warnings on en.json clear after the next sync.

🤖 Generated with Claude Code

Weblate's plural-form check flagged 11 source strings in en.json that
used the "word(s)" idiom to indicate one-or-more. This form doesn't
translate cleanly to languages with multiple plural categories
(Russian, Arabic, Polish, etc.), forcing translators to lose the
meaning.

Fixes:
- 5 static UI strings rephrased to plain plural (Upload Images,
  Enter hotkeys, the model files, Incompatible LoRAs, raster layers).
- 6 count-driven strings (delete/reidentify model toasts and
  confirmation prompts) split into proper i18next `_one` / `_other`
  key pairs. All call sites already pass `count`, so no code changes
  were required.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the frontend PRs that change frontend files label May 15, 2026
@lstein lstein added the v6.13.x label May 15, 2026
@lstein lstein moved this to 6.13.x Theme: MODELS in Invoke - Community Roadmap May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files v6.13.x

Projects

Status: 6.13.x Theme: MODELS

Development

Successfully merging this pull request may close these issues.

2 participants