fix(i18n): replace "(s)" parenthetical plurals flagged by Weblate#9179
Open
lstein wants to merge 1 commit into
Open
fix(i18n): replace "(s)" parenthetical plurals flagged by Weblate#9179lstein wants to merge 1 commit into
lstein wants to merge 1 commit into
Conversation
Weblate's plural-form check flagged 11 source strings in en.json that used the "word(s)" idiom to indicate one-or-more. This form doesn't translate cleanly to languages with multiple plural categories (Russian, Arabic, Polish, etc.), forcing translators to lose the meaning. Fixes: - 5 static UI strings rephrased to plain plural (Upload Images, Enter hotkeys, the model files, Incompatible LoRAs, raster layers). - 6 count-driven strings (delete/reidentify model toasts and confirmation prompts) split into proper i18next `_one` / `_other` key pairs. All call sites already pass `count`, so no code changes were required. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
en.jsonfor the plural-form check because they used theword(s)parenthetical idiom — a construct that can't be translated cleanly into languages with multiple plural categories (Russian, Arabic, Polish, etc.).Upload Image(s),Enter hotkey(s)…,model file(s),Incompatible LoRA(s) added,raster layer(s)) rephrased to plain plural form._one/_otherkey pairs. Every call site already passescount: …, so no.ts/.tsxchanges were needed — i18next picks the correct form automatically.Notes
_oneform ofreidentifyModelsConfirmwas also corrected from…re-probe their weights files…to…re-probe its weights file…so the singular grammar reads naturally.de.json, etc.) are unaffected at runtime — i18next falls back toen.jsonfor missing keys, and translators will pick up the new key shape on the next Weblate sync.Test plan
Bulk Deleteconfirmation reads correctly for 1 model vs. N models.Bulk Reidentifyconfirmation reads correctly for 1 model vs. N models (note grammar shift on weights file/files).modelsDeleted,someModelsFailedToDelete,modelsReidentified,someModelsFailedToReidentify) render the right singular/plural form.(s).en.jsonclear after the next sync.🤖 Generated with Claude Code