fix(publish): only report success when dart pub exits 0 - #1061
Open
AzazelSensei wants to merge 1 commit into
Open
fix(publish): only report success when dart pub exits 0#1061AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Dry-run can fail with exit 65 (older patch vs a newer version on the registry). We treated anything other than 1 as success, so the log said FAILED and then "validated successfully".
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
melos publish --dry-runrunsdart pub publish --dry-run. That can exit 65 for a backport / older patch even when a real publish would work (dart-lang/pub#4696). Exec prints FAILED, then we printed "All packages were validated successfully" because the check wasexitCode != 1.Only print success when the exec exit code is 0.
Fixes #966
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore