Skip to content

Deprecate convert for closed intervals in favor of only - #145

Open
p-zubieta wants to merge 3 commits into
invenia:masterfrom
p-zubieta:pz/to_scalar
Open

Deprecate convert for closed intervals in favor of only#145
p-zubieta wants to merge 3 commits into
invenia:masterfrom
p-zubieta:pz/to_scalar

Conversation

@p-zubieta

Copy link
Copy Markdown
Contributor

Another take on #144 as suggested in #143. I don't know if this is the best name for this function nor how the presence of the deprecation affects removing the method. But throwing the idea here anyway to keep the ball rolling.

@p-zubieta
p-zubieta requested a review from omus as a code owner October 7, 2020 04:24
@p-zubieta
p-zubieta force-pushed the pz/to_scalar branch 2 times, most recently from a8fa689 to f3165b3 Compare October 8, 2020 03:42
@codecov

codecov Bot commented Oct 8, 2020

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.93%. Comparing base (e04f9d4) to head (9167160).
⚠️ Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   81.73%   81.93%   +0.20%     
==========================================
  Files          11       11              
  Lines         624      631       +7     
==========================================
+ Hits          510      517       +7     
  Misses        114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@p-zubieta

Copy link
Copy Markdown
Contributor Author

@omus was something like this what you had in mind here?

@nalimilan

Copy link
Copy Markdown

Maybe making this a method of only would make sense?

@KristofferC

KristofferC commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

Bump, I'm seeing thousands of invalidations less with this PR (for a big package I am looking at).

The next big one is

Base.:(==)(a, b::Endpoint) = a == b.endpoint && isclosed(b)
Base.:(==)(a::Endpoint, b) = b == a

givinb 2.6k invalidations.

@p-zubieta

Copy link
Copy Markdown
Contributor Author

For the latter there is #143.

@omus

omus commented Mar 24, 2021

Copy link
Copy Markdown
Collaborator

@omus was something like this what you had in mind here?

Yes, this is. I was thinking of using an alternative function name like scalar but only seems quite reasonable

@omus omus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a few changes and a rebase to get the CI working I think we can get this merged

Comment thread src/anchoredinterval.jl
Comment thread src/anchoredinterval.jl Outdated
Comment thread src/interval.jl Outdated
@p-zubieta
p-zubieta force-pushed the pz/to_scalar branch 4 times, most recently from 7e04521 to 44dece7 Compare January 17, 2022 18:27
@p-zubieta

Copy link
Copy Markdown
Contributor Author

The failing tests are unrelated, but I' not sure about the docs failure.

@p-zubieta p-zubieta changed the title Replace convert for scalars Deprecate convert for closed intervals in favor of only Jan 25, 2022

@omus omus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor things left here

Comment thread src/interval.jl Outdated
Comment thread test/interval.jl Outdated
Comment thread src/interval.jl Outdated
Comment thread src/interval.jl
@p-zubieta
p-zubieta force-pushed the pz/to_scalar branch 3 times, most recently from 52db1b2 to 03a4ecd Compare February 19, 2022 15:48
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
@p-zubieta
p-zubieta requested a review from omus February 19, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants