Deprecate convert for closed intervals in favor of only - #145
Conversation
a8fa689 to
f3165b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 81.73% 81.93% +0.20%
==========================================
Files 11 11
Lines 624 631 +7
==========================================
+ Hits 510 517 +7
Misses 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Maybe making this a method of |
|
Bump, I'm seeing thousands of invalidations less with this PR (for a big package I am looking at). The next big one is Lines 148 to 149 in 8474023 givinb 2.6k invalidations. |
|
For the latter there is #143. |
omus
left a comment
There was a problem hiding this comment.
With a few changes and a rebase to get the CI working I think we can get this merged
7e04521 to
44dece7
Compare
|
The failing tests are unrelated, but I' not sure about the docs failure. |
44dece7 to
d912e21
Compare
d912e21 to
ee77d7a
Compare
omus
left a comment
There was a problem hiding this comment.
Only some minor things left here
52db1b2 to
03a4ecd
Compare
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
03a4ecd to
6452e0b
Compare
Another take on #144 as suggested in #143. I don't know if this is the best name for this function nor how the presence of the
deprecationaffects removing the method. But throwing the idea here anyway to keep the ball rolling.