Skip to content

Fix: remove_if called without erase #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OfekShilon wants to merge 9 commits into
base: main
Choose a base branch
from
+121 −12
Open

Fix: remove_if called without erase #194

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ccc9b40
Fix: `remove_if` called without `erase`
OfekShilon Dec 7, 2023
29cb617
Fix build
OfekShilon Dec 7, 2023
011aed3
Handle exe names for windows
OfekShilon Dec 21, 2023
1cfb063
Warning fix
OfekShilon Dec 21, 2023
bccfb28
Introduce test_sets_win.txt
OfekShilon Dec 21, 2023
0a0ec50
More fixes towards windows conformance
OfekShilon Dec 21, 2023
a67e294
Make run_gen.py work on windows
OfekShilon Dec 16, 2023
b0d539b
Aim to run from wsl, start fixing makefil generation
OfekShilon Dec 22, 2023
78fb0c1
Add vscode debug config for windows in launch.json
OfekShilon Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/gen_policy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,8 @@ void GenPolicy::uniformProbFromMax(std::vector<Probability<T>> &distr,

template <class T, class U>
void GenPolicy::removeProbability(std::vector<Probability<T>> &orig, U id) {
std::remove_if(
auto new_end = std::remove_if(
orig.begin(), orig.end(),
[&id](Probability<T> &elem) -> bool { return elem.getId() == id; });
orig.erase(new_end, orig.end());
}