[SYCL free func] migrate AmpKernels kernels - #4864
Open
minmingzhu wants to merge 1 commit into
Open
Conversation
minmingzhu
marked this pull request as draft
August 7, 2026 10:35
minmingzhu
marked this pull request as ready for review
August 10, 2026 01:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AmpKernels.cpp — Kernel UT Report
SYCL kernel conversion check: In src/ATen/native/xpu/sycl/AmpKernels.cpp, amp_update_scale_ff_kernel (line 118) is implemented/launched as a free function via SYCL_EXT_ONEAPI_FUNCTION_PROPERTY((syclexp::nd_range_kernel<1>)) and sycl_kernel_submit<amp_update_scale_ff_kernel>(...) function pointer.
The remaining *Functor structs in this file (AmpNonFiniteCheckUnscaleFunctor, AmpForeachNonFiniteCheckUnscaleFunctor) are element-wise operation functors passed to gpu_kernel() / multi_tensor_apply() (TensorIterator/foreach infrastructure) and are not SYCL kernel launch functors.
Changed-kernel related UTs run in both locations: