invite date-pending enrollments to invite_all conferences - #2654
Open
ffdixon wants to merge 1 commit into
Open
Conversation
conferences created before a course start date silently dropped all invitees: participating_users filters by enrollment_states.state = 'active', and students are 'pending_active' until the start date passes - an event that never re-triggers conference sync. use the active_or_pending_by_date scope instead; the :join policy still blocks access until the course is readable. fixes instructuregh-2653 flag=none test plan: - create a course with a future start date and "students can only participate between these dates" - enroll students, create a conference inviting all course members - confirm students appear as conference invitees - enroll another student before the start date; confirm they are added to the conference - conclude a student; confirm they are not invited Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conferences created before a course start date silently dropped all invitees because
participating_usersfilters byenrollment_states.state = 'active', while students remainpending_activeuntil the course start date. Since the start date transition updates onlyenrollment_states(notenrollments.workflow_state), conference synchronization is never re-triggered. Use theactive_or_pending_by_datescope instead; the existing:joinpolicy still prevents access until the course is readable.fixes gh-2653
flag=none
test plan: