Skip to content

Classic Quiz with Assignment. Quiz Question Create/Update Triggers Live Event. #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
braysch wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −0
Open

Classic Quiz with Assignment. Quiz Question Create/Update Triggers Live Event. #2600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/observers/live_events_observer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class LiveEventsObserver < ActiveRecord::Observer
:user_account_association,
:user,
:wiki_page,
"Quizzes::QuizQuestion",
"MasterCourses::MasterTemplate",
"MasterCourses::MasterMigration",
"MasterCourses::ChildSubscription",
Expand Down
6 changes: 6 additions & 0 deletions lib/canvas/live_events_callbacks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ def self.after_create(obj)
Canvas::LiveEvents.group_membership_created(obj)
when WikiPage
Canvas::LiveEvents.wiki_page_created(obj)
when Quizzes::QuizQuestion
assignment = obj.quiz&.assignment
Canvas::LiveEvents.assignment_updated(assignment) if assignment
when Assignment
Canvas::LiveEvents.assignment_created(obj)
when AssignmentGroup
Expand Down Expand Up @@ -135,6 +138,9 @@ def self.after_update(obj, changes)
changes["title"]&.first,
changes["body"]&.first)
end
when Quizzes::QuizQuestion
assignment = obj.quiz&.assignment
Canvas::LiveEvents.assignment_updated(assignment) if assignment
when Assignment
Canvas::LiveEvents.assignment_updated(obj)
when AssignmentGroup
Expand Down
19 changes: 19 additions & 0 deletions spec/observers/live_events_observer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,25 @@ def enable_quizzes_next(course)
end
end

describe "quiz_question" do
it "posts assignment_updated when a question is created" do
allow(Canvas::LiveEvents).to receive(:assignment_updated)
quiz_model(quiz_type: "assignment")
assignment = @quiz.reload.assignment
expect(Canvas::LiveEvents).to receive(:assignment_updated).with(assignment)
@quiz.quiz_questions.create!(question_data: { name: "Q1", question_type: "true_false_question", points_possible: 1 })
end

it "posts assignment_updated when a question is updated" do
allow(Canvas::LiveEvents).to receive(:assignment_updated)
quiz_model(quiz_type: "assignment")
question = @quiz.quiz_questions.create!(question_data: { name: "Q1", question_type: "true_false_question", points_possible: 1 })
assignment = @quiz.reload.assignment
expect(Canvas::LiveEvents).to receive(:assignment_updated).with(assignment)
question.update!(question_data: { name: "Q1 updated", question_type: "true_false_question", points_possible: 1 })
end
end

describe "content_migration_completed" do
it "posts update events" do
expect(Canvas::LiveEvents).to receive(:content_migration_completed).once
Expand Down