Skip to content

[Playground] OTLP-Mapper - instana to otlp span mapper #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
abhilash-sivan wants to merge 17 commits into
base: chore-otlp-playground
Choose a base branch
from
Draft

[Playground] OTLP-Mapper - instana to otlp span mapper #2534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
378f117
chore: phase 1
abhilash-sivan May 4, 2026
c1ef77d
chore: phase 2
abhilash-sivan May 4, 2026
d261bc5
chore: phase 3
abhilash-sivan May 7, 2026
17710d0
chore: cleanup
abhilash-sivan May 7, 2026
0a6ec17
chore: rewrite
abhilash-sivan May 7, 2026
8a89eef
chore: test
abhilash-sivan May 7, 2026
c78331c
chore: a
abhilash-sivan May 7, 2026
bcb034e
chore: new fields
abhilash-sivan May 7, 2026
980a1c0
chore: test
abhilash-sivan May 7, 2026
5aebc15
test: fixed failing test
abhilash-sivan May 10, 2026
8c6cc88
chore: cleanup
abhilash-sivan May 10, 2026
c3179eb
chore: ui corrected
abhilash-sivan May 13, 2026
21c211d
chore: added kafka and pg, generalize
abhilash-sivan May 14, 2026
fcd7622
chore: update
abhilash-sivan May 14, 2026
c1253b0
chore: fix
abhilash-sivan May 15, 2026
d6c01a6
chore: clean
abhilash-sivan May 15, 2026
efd4103
chore: update
abhilash-sivan May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/collector/src/agentConnection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const pathUtil = require('path');
const circularReferenceRemover = require('./util/removeCircular');
const agentOpts = require('./agent/opts');
const cmdline = require('./cmdline');
const otlpTransformer = require('./otlpTransformer');
const otlpTransformer = require('@instana/core/src/tracing/otlpTransformer');
Copy link
Copy Markdown
Contributor

@kirrg001 kirrg001 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please reset the file? I think no changes needed as part of this playground, right?

Copy link
Copy Markdown
Contributor Author

@abhilash-sivan abhilash-sivan May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no major changes here. Only the relevant change is removing the Otel span transforming logic from this file

/** @typedef {import('@instana/core/src/core').InstanaBaseSpan} InstanaBaseSpan */

/** @type {import('@instana/core/src/core').GenericLogger} */
Expand Down Expand Up @@ -314,7 +314,7 @@ exports.sendMetrics = function sendMetrics(data, cb) {
firstTwoKeys[dataKeys[i]] = data[dataKeys[i]];
}

logger.debug(`sendMetrics called with data (first 2 keys): ${JSON.stringify(firstTwoKeys)}`);
// logger.debug(`sendMetrics called with data (first 2 keys): ${JSON.stringify(firstTwoKeys)}`);

// Transform Instana metrics to OTLP format
const otlpMetrics = otlpTransformer.transformMetrics(data);
Expand Down Expand Up @@ -344,15 +344,15 @@ exports.sendMetrics = function sendMetrics(data, cb) {
}
}

logger.debug(`Transformed to OTLP (first 2 metrics) ${JSON.stringify(otlpPreview)}`);
// logger.debug(`Transformed to OTLP (first 2 metrics) ${JSON.stringify(otlpPreview)}`);

// Send directly without using sendData (which would transform again)
sendOtlpData('/v1/metrics', otlpMetrics, err => {
if (err) {
logger.error('Error sending metrics:', err);
cb(err, null);
} else {
logger.debug('Metrics sent successfully');
// logger.debug('Metrics sent successfully');
// OTLP endpoints don't return requests like the old Instana endpoint
// Always return empty array for compatibility
cb(null, []);
Expand All @@ -370,10 +370,10 @@ exports.sendSpans = function sendSpans(spans, cb) {
if (err && !maxContentErrorHasBeenLogged && err instanceof PayloadTooLargeError) {
logLargeSpans(spans);
} else if (err) {
const spanInfo = getSpanLengthInfo(spans);
const spanInfo = spans;
logger.debug(`Failed to send: ${JSON.stringify(spanInfo)}`);
} else {
const spanInfo = getSpanLengthInfo(spans);
const spanInfo = spans;
logger.debug(`Successfully sent: ${JSON.stringify(spanInfo)}`);
}
cb(err);
Expand Down Expand Up @@ -475,11 +475,11 @@ function sendData(path, data, cb, ignore404 = false) {
cb = util.atMostOnce(`callback for sendData: ${path}`, cb);
console.log(JSON.stringify(data));
// Transform Instana format to OTLP format
const otlpFormat = otlpTransformer(data);
// const otlpFormat = otlpTransformer(data);

console.log(JSON.stringify(otlpFormat));
// console.log(JSON.stringify(otlpFormat));

const payloadAsString = JSON.stringify(otlpFormat, circularReferenceRemover());
const payloadAsString = JSON.stringify(data, circularReferenceRemover());
Comment thread
abhilash-sivan marked this conversation as resolved.
if (typeof logger.trace === 'function') {
logger.trace(`Sending data to ${path}.`);
} else {
Expand Down
Loading