Lab 3: PR-gated CI for QuickNotes (vet + test + lint)#1092
Open
danielpancake wants to merge 10 commits into
Open
Lab 3: PR-gated CI for QuickNotes (vet + test + lint)#1092danielpancake wants to merge 10 commits into
danielpancake wants to merge 10 commits into
Conversation
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
09c4773 to
19c587c
Compare
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
Signed-off-by: danielpancake <45727078+danielpancake@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add a PR-gated CI pipeline for QuickNotes that runs vet, test, and lint on every PR to
main, hardened with SHA-pinned actions and sped up with caching and a Go version matrix.Changes
.github/workflows/ci.yml: three independent required units (vet,test,lint) on pinnedubuntu-24.04, Go pinned,golangci-lint v2.5.0pinned.permissions: contents: readat workflow level.1.23+1.24matrix on vet/test (fail-fast: false), path filter (app/**,.github/workflows/**), and a singleci-okaggregation gate.submissions/lab3.md: chosen path, evidence screenshots, baseline/cache/cache+matrix timing table, and design answers a-h.Testing
testred, merge blocked) in0f250b6, reverted to green in19c587c.mainrequires theci-okcheck (strict, admin-enforced).Checklist
git log --show-signature)submissions/lab3.mdupdated