The bottom resize grabber no longer lingers when the terminal is…#439
Merged
Conversation
…#2364) * fix(open-knowledge): hide bottom terminal grabber when right-docked TerminalDock gated its bottom resize handle on the visible prop alone. A right-docked terminal keeps visible true while the bottom panel sits collapsed and empty, so the grabber pill stayed rendered and draggable, pulling up an empty panel. Gate the handle (grabber render, disabled state, and the pointer-down guard) on bottom-docked-and-visible instead, and reuse the same predicate for the panel restore effect and initial size. Docking back to the bottom restores the grabber. Web and embedded hosts never mount TerminalDock (no terminal bridge), so this only changes the desktop app. * review polish: canonical dock-position type in test, tighter comments Import TerminalDockPosition from terminal-dock-store in the dock test instead of redeclaring the union locally, drop the comment sentence that restated the bottomOpen expression, and make the disabled-handle comment name where each way back in actually lives (bottom reveal tab here; EditorArea reveal tab and tab-strip dock-toggle when right-docked). GitOrigin-RevId: 240b1b101d7750e42fa561aca12b94777b1057db
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/u/123133689?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28573618265). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bottom resize grabber no longer lingers when the terminal is docked to the right column. Previously the grabber stayed visible and could be dragged up to reveal an empty bottom panel; it now disappears while the terminal is right-docked and returns when you dock the terminal back to the bottom.