fix(ok-marketing): own full brand surface + split-regression fixes#435
Merged
Conversation
…2358) * fix(ok-marketing): own full brand surface + split-regression fixes Consolidate the entire brand surface into the marketing app and fix the regressions left by the docs/marketing separation (#2334). Marketing: - move the /brand page here (renders under SiteNav) and serve the kit from public/marketing-assets/brand/ - restore the logo right-click menu (copy/download SVG+PNG, link to /brand) - render our own OG brand card at /marketing-assets/og, removing the cross-zone dependency on the docs /opengraph-image route - MarketingButton: honor the download prop by rendering a raw anchor, so SVG/PNG/zip download instead of opening inline - add an explicit homepage canonical Docs: - remove the brand page and kit binaries; route /brand to marketing - trim brand-assets to BRAND_ROUTE (still used by sitemap and footer) * fix(ok-marketing): restore /brand slide chrome; shrink SVG/PNG buttons Add back the cream slide-bg + dot-texture pair the /brand page had in the docs SlidePageShell, and make the per-asset SVG/PNG download buttons compact (smaller padding + text) instead of the full tertiary size. * fix(ok-marketing): tighten /brand description copy * fix(ok-marketing): shorten /brand heading to 'Brand assets' * fix(ok-marketing): match /brand background to home; retitle heading Drop the cream slide-bg override on /brand so it uses the same body surface as the marketing home page (keeping the dot textures), and retitle the heading to "Logos & icons" since the eyebrow already says Brand. * fix(open-knowledge): drop orphaned docs section-heading after brand move knip flagged docs/src/components/section-heading.tsx as unused: the docs brand page (its only consumer) moved to the marketing app, so the docs copy is dead code. The marketing app has its own section-heading. * fix(ok-marketing): address review nits (token parity, regen comment) - ContextMenu: use the default border token + bg-slide-border separator to match sibling DropdownMenu (was border-slide-text/10 + bg-slide-text/10) - ok-wordmark.data.ts: clarify the artifact is generated in the docs app and copied (no marketing-tree regen script) * fix(ok-marketing): update stale footer /brand comment /brand is now a marketing-zone route (this app owns the brand surface), not docs-zone-served. Flagged in review. GitOrigin-RevId: 006bfebce82bc7553f82e55a7f06f71a81c76fdc
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/u/123133689?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28563223938). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.