Skip to content

chore: improve instrumentation #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Fraser999 wants to merge 1 commit into
base: fraser/eng-2016/complete-journal-integration
Choose a base branch
from
+10 −3
Draft

chore: improve instrumentation #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/node/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,14 @@ where
sync_token,
applied_rollup_height,
);
info!("journal sync started");
info!(
primary_height = checkpoints.primary.height,
primary_hash = %checkpoints.primary.hash,
fallback_height = checkpoints.fallback.height,
fallback_hash = %checkpoints.fallback.hash,
sources = ?self.config.journal().sources(),
"journal sync started",
);

let outcome = journal_sync_loop(
&mut self.notifier,
Expand Down Expand Up @@ -559,7 +566,7 @@ where
transactions: executed.transactions.iter().map(|tx| tx.inner().clone()).collect(),
receipts: executed.receipts.clone(),
};
self.emit_journal(journal_bytes).await?;
self.emit_journal(block_extracts.ru_height, journal_bytes).await?;
self.storage.append_blocks(vec![executed]).await?;
let _ = self.chain.send_new_block(notification);
processed = true;
Expand Down Expand Up @@ -615,7 +622,7 @@ where
/// only failure mode is the receiver being closed, which means the
/// ingestion task has exited and the node cannot continue.
#[instrument(skip(self, bytes), fields(len = bytes.len()))]
async fn emit_journal(&self, bytes: Bytes) -> eyre::Result<()> {
async fn emit_journal(&self, ru_height: u64, bytes: Bytes) -> eyre::Result<()> {
self.journal_sender
.send(bytes)
.await
Expand Down
Loading