refactor: duplicate e2e - #30773
Merged
Merged
Conversation
danieldietzler
approved these changes
Aug 14, 2026
jrasm91
enabled auto-merge (squash)
August 14, 2026 20:54
Deeds67
added a commit
to open-noodle/gallery
that referenced
this pull request
Aug 15, 2026
…te medium spec Two CI-only fallout items from batches 96-101. - immich-app#30773 converted the duplicate suite from an e2e spec to a medium test. The e2e version ran the real DI container, so the fork's #317 space-membership carry-over in resolveGroup always found SharedSpaceRepository; a medium test declares its dependencies explicitly and upstream's list only names upstream's. Every resolve therefore threw 'Cannot read properties of undefined (reading getEditableByAssetIds)' and was reported as success:false / error:unknown, failing 14 of 25 tests. Registered as real, not mocked: these fixtures create no spaces, so it is a genuine empty-set round trip rather than a stub that can drift. 25/25 pass locally. - Trailing blank line left in album.service.ts by the handleConfirmAlbumDelete removal; eslint is clean on it but prettier is a separate CI gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate duplicate e2e to medium tests.