Skip to content

fix: shared link create validation - #30762

Merged
danieldietzler merged 1 commit into
mainfrom
fix/shared-link-create-validation
Aug 14, 2026
Merged

fix: shared link create validation#30762
danieldietzler merged 1 commit into
mainfrom
fix/shared-link-create-validation

Conversation

@danieldietzler

Copy link
Copy Markdown
Member

No description provided.

@danieldietzler
danieldietzler force-pushed the fix/shared-link-create-validation branch 2 times, most recently from f85fa9a to 1760c80 Compare August 14, 2026 10:25
@danieldietzler
danieldietzler requested a review from jrasm91 August 14, 2026 11:12

@jrasm91 jrasm91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adjust the error messages to be:

  • when type is album and no album id: "albumId is required"
  • when type is album and asset ids are provided: "assetIds can only be used with type: individual"
  • when type is individual and album id is provided: "albumId can only be used with type: album"
  • when type is individual and assets ids is not provided: "assetIds area required"

@danieldietzler
danieldietzler force-pushed the fix/shared-link-create-validation branch 3 times, most recently from a4bfb72 to e60af4e Compare August 14, 2026 19:07
@danieldietzler
danieldietzler requested a review from jrasm91 August 14, 2026 19:07

@jrasm91 jrasm91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, ty

@danieldietzler
danieldietzler force-pushed the fix/shared-link-create-validation branch from e60af4e to b5273a7 Compare August 14, 2026 19:41
@danieldietzler
danieldietzler merged commit 6a61901 into main Aug 14, 2026
56 checks passed
@danieldietzler
danieldietzler deleted the fix/shared-link-create-validation branch August 14, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants