Decouple Fuel System using GameSettingsResource and Signals#534

Merged

ikostan merged 79 commits intomainfrom

convert-hard-coded-fuel-elements-to-godot-resource

Apr 10, 2026

Commits on Apr 7, 2026

Commits on Apr 8, 2026

Commits on Apr 9, 2026

Introduce a Godot Resource that centralizes fuel configuration
ikostan
committed
Update player.gd
ikostan
committed
Update player.gd
ikostan
committed
Update player.gd
ikostan
committed
Add automated unit tests for core fuel logic
ikostan
committed
Add tests for persistence and UI integration of the fuel system
ikostan
committed
Update test_fuel_persistence_integration.gd
ikostan
committed
issue (bug_risk): The setters for max_fuel and current_fuel are recursively assigning to the same property, which is likely to cause infinite recursion.
ikostan
committed
question (bug_risk): Resetting current_fuel to max on player spawn may conflict with persisted fuel state or mid-run reloads.
ikostan
committed
Update test/gut/test_fuel_additional_edge_cases..gd

ikostan
and
coderabbitai[bot]
authored
Merge branch 'convert-hard-coded-fuel-elements-to-godot-resource' of https://github.com/ikostan/SkyLockAssault into convert-hard-coded-fuel-elements-to-godot-resource
ikostan
committed
Update test/gut/test_fuel_persistence_integration.gd

ikostan
and
coderabbitai[bot]
authored
Need to explicitly sever the ties before the node leaves the tree
ikostan
committed
Merge branch 'convert-hard-coded-fuel-elements-to-godot-resource' of https://github.com/ikostan/SkyLockAssault into convert-hard-coded-fuel-elements-to-godot-resource
ikostan
committed
Update player.gd
ikostan
committed
Update main_scene.tscn
ikostan
committed
Update player.gd
ikostan
committed
issue (bug_risk): The current_fuel setter recursively assigns to itself, which will cause infinite recursion at runtime.
ikostan
committed
Update game_settings_resource.gd
ikostan
committed
issue (bug_risk): Threshold setters assign to their own exported properties, leading to recursion rather than updating a backing field.
ikostan
committed
Update game_settings_resource.gd
ikostan
committed
Update game_settings_resource.gd
ikostan
committed
issue (bug_risk): Fuel warning uses absolute current_fuel vs a threshold that is treated as a percentage elsewhere, which makes behavior inconsistent when max_fuel changes.
ikostan
committed
The new test file test_fuel_additional_edge_cases..gd has a double dot in its filename and references
ikostan
committed
Update test_fuel_persistence_integration.gd
ikostan
committed
issue: The max_fuel setter can indirectly force current_fuel to 0 and emit fuel_depleted in some edge configurations.
ikostan
committed
Update player.gd
ikostan
committed
Update player.gd
ikostan
committed
issue: Guard against invalid or equal fuel threshold values that would make the lerp denominators zero or negative.
ikostan
committed
Update test_fuel_additional_edge_cases.gd
ikostan
committed
Update player.gd
ikostan
committed
Update player.gd
ikostan
committed
suggestion (bug_risk): The cached _settings reference is not used consistently, which partly defeats the null-guard and may desync from Globals.settings.
ikostan
committed
Update game_settings_resource.gd
ikostan
committed
Update game_settings_resource.gd
ikostan
committed
Update game_settings_resource.gd
ikostan
committed
Update player.gd
ikostan
committed
Update player.gd
ikostan
committed
Update test/gut/test_fuel_additional_edge_cases.gd

ikostan
and
coderabbitai[bot]
authored
Update scripts/player.gd

ikostan
and
coderabbitai[bot]
authored
Update player.gd
ikostan
committed

Commits on Apr 10, 2026